diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2020-01-14 12:26:52 +0100 |
|---|---|---|
| committer | Adolfo Jayme Barrientos <fitojb@ubuntu.com> | 2020-01-16 01:47:24 +0100 |
| commit | 4c3bde3b4bddb6bcfe0ae5b269d3b0f50c23236f (patch) | |
| tree | f77f1f42bf4cbb64a25fb656163bdf46b2420411 | |
| parent | 2a676d8dcf5404a0b82e9d99c66579170b1a8690 (diff) | |
do not ignore return value of a (confusing) function (tdf#126248)
The two ScCellFormat::GetString() overloads are lame API, one returns
the value normally and the other one returns void and uses a reference
parameter. I got confused by this in 6f810e3d7dafcd7d0101173a501
and didn't use the return value in one case.
Change-Id: I0b6c839f9d0299e14ea022813481802275df5ea6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86750
Tested-by: Jenkins
Reviewed-by: 锁琨珑 <suokunlong@126.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
(cherry picked from commit 5a211ba9f5f465c8c898ebce4cc37fa30581acac)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86838
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
| -rw-r--r-- | sc/source/core/data/documen6.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/source/core/data/documen6.cxx b/sc/source/core/data/documen6.cxx index 9dd1f8b523a3..bc0f7aa11afa 100644 --- a/sc/source/core/data/documen6.cxx +++ b/sc/source/core/data/documen6.cxx @@ -120,7 +120,7 @@ SvtScriptType ScDocument::GetCellScriptType( const ScAddress& rPos, sal_uInt32 n if( pCell ) ScCellFormat::GetString(*pCell, nNumberFormat, aStr, &pColor, *mxPoolHelper->GetFormTable(), this); else - ScCellFormat::GetString(*this, rPos, nNumberFormat, &pColor, *mxPoolHelper->GetFormTable()); + aStr = ScCellFormat::GetString(*this, rPos, nNumberFormat, &pColor, *mxPoolHelper->GetFormTable()); SvtScriptType nRet = GetStringScriptType( aStr ); |