diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2015-01-31 21:11:57 +0000 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2015-04-04 20:30:34 +0200 |
| commit | 15487c3f0fde61012ea69f88c64cdcd2017733b3 (patch) | |
| tree | 5a221d5a0072b514dea68ed8f65e11b253edbdbd | |
| parent | b1bede525c68e628456bf8cbe9ecc855d2307612 (diff) | |
coverity#1267678 this is surely backwards (gold)
surely we clone from the source and return the newly created
entry. Presumably this doesn't break all the time because
aCloneLink is generally set ?
coverity#1267678 Resource leak
Change-Id: I3e02dfaef371e006f1510b186cdd881c991ef2cf
(cherry picked from commit 9f1ecd3ac35f06746fe2a12ca52899f664679de5)
Reviewed-on: https://gerrit.libreoffice.org/15023
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
| -rw-r--r-- | svtools/source/contnr/treelist.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/svtools/source/contnr/treelist.cxx b/svtools/source/contnr/treelist.cxx index cbd011a524eb..202993187dfe 100644 --- a/svtools/source/contnr/treelist.cxx +++ b/svtools/source/contnr/treelist.cxx @@ -355,8 +355,8 @@ SvTreeListEntry* SvTreeList::CloneEntry( SvTreeListEntry* pSource ) const if( aCloneLink.IsSet() ) return (SvTreeListEntry*)aCloneLink.Call( pSource ); SvTreeListEntry* pEntry = CreateEntry(); - pSource->Clone( pEntry ); - return pSource; + pEntry->Clone(pSource); + return pEntry; } SvTreeListEntry* SvTreeList::CreateEntry() const |