summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLionel Elie Mamane <lionel@mamane.lu>2013-07-10 02:58:01 +0200
committerLionel Elie Mamane <lionel@mamane.lu>2013-07-10 03:15:13 +0200
commit83076c22e1ffbad06f4b250b69cd239758fbb1ba (patch)
tree0fe54dc1d4cc3e5eb1ddcffac74587c6f9b73a21
parentc9a8f238e03f7b4e54f5a963a6593888759ae3fa (diff)
TODO note
Change-Id: I1b310119c08052949e975bfa3838e229d4e140b2
-rw-r--r--connectivity/source/parse/sqliterator.cxx7
1 files changed, 7 insertions, 0 deletions
diff --git a/connectivity/source/parse/sqliterator.cxx b/connectivity/source/parse/sqliterator.cxx
index bb271b9254f5..0ae7b834ff03 100644
--- a/connectivity/source/parse/sqliterator.cxx
+++ b/connectivity/source/parse/sqliterator.cxx
@@ -589,6 +589,13 @@ const OSQLParseNode* OSQLParseTreeIterator::getTableNode( OSQLTables& _rTables,
if ( SQL_ISRULE( pQueryExpression, select_statement ) )
{
getSelect_statement( *m_pImpl->m_pSubTables, pQueryExpression );
+ // LEM TODO: now, we need to setup a OSQLTable from pQueryExpression in some way
+ // and stick it in _rTables[rTableRange]. Probably fake it by
+ // setting up a full OSQLParseTreeIterator on pQueryExpression
+ // and using its m_aSelectColumns
+ // This is necessary in stuff like "SELECT * FROM tbl1 INNER JOIN (SELECT foo, bar FROM tbl2) AS tbl3"
+ // so that setSelectColumnName() can expand the "*" correctly.
+ // See e.g. R_UserAndLastSubscription query of https://bugs.freedesktop.org/attachment.cgi?id=71871
}
else
{