summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2022-06-22 16:05:53 +0100
committerMichael Stahl <michael.stahl@allotropia.de>2022-09-22 21:54:37 +0200
commit63629f9be564b5bf9f15f6484cc07b6e699fa788 (patch)
treee1e2fb5f78c908f19c3d7ce3834309b89cb5a968
parent26446c1061bc8ad1b125bd29e4a439931a4c1b68 (diff)
crashtesting: assert seen with forum-mso-de-53682
not reproducible for me, but appears to be an empty string here sometimes. Change-Id: I8465f178cc7e5a6efdc08c1d15c154eeb2277c7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136247 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit dff039e61ac737c779b538d20a57a5e0a401cf60)
-rw-r--r--formula/source/core/api/token.cxx8
1 files changed, 6 insertions, 2 deletions
diff --git a/formula/source/core/api/token.cxx b/formula/source/core/api/token.cxx
index 17594207234f..cc5fb5426a70 100644
--- a/formula/source/core/api/token.cxx
+++ b/formula/source/core/api/token.cxx
@@ -1193,8 +1193,12 @@ bool FormulaMissingContext::AddMissingExternal( FormulaTokenArray *pNewArr ) con
const OUString &rName = mpFunc->GetExternal();
- // initial (fast) check:
- sal_Unicode nLastChar = rName[ rName.getLength() - 1];
+ // initial (fast) checks:
+ sal_Int32 nLength = rName.getLength();
+ if (!nLength)
+ return false;
+
+ sal_Unicode nLastChar = rName[ nLength - 1];
if ( nLastChar != 't' && nLastChar != 'm' )
return false;