summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2015-01-31 21:11:57 +0000
committerDavid Tardon <dtardon@redhat.com>2015-03-27 08:05:53 +0000
commit3eba5eb1774ab621a1f0f4dcc7e82cce6c025b0a (patch)
tree35991ce2fa91140f2a5a4497f5a3009349ce2ded
parent9dfad2baaf1f9c6d0933b2326cbf2ff522ae73d1 (diff)
coverity#1267678 this is surely backwards (gold)cp-4.4-branch-point
surely we clone from the source and return the newly created entry. Presumably this doesn't break all the time because aCloneLink is generally set ? coverity#1267678 Resource leak Change-Id: I3e02dfaef371e006f1510b186cdd881c991ef2cf (cherry picked from commit 9f1ecd3ac35f06746fe2a12ca52899f664679de5) Reviewed-on: https://gerrit.libreoffice.org/15022 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
-rw-r--r--svtools/source/contnr/treelist.cxx4
1 files changed, 2 insertions, 2 deletions
diff --git a/svtools/source/contnr/treelist.cxx b/svtools/source/contnr/treelist.cxx
index 60a8d27855c8..1da2c9856d52 100644
--- a/svtools/source/contnr/treelist.cxx
+++ b/svtools/source/contnr/treelist.cxx
@@ -355,8 +355,8 @@ SvTreeListEntry* SvTreeList::CloneEntry( SvTreeListEntry* pSource ) const
if( aCloneLink.IsSet() )
return reinterpret_cast<SvTreeListEntry*>(aCloneLink.Call( pSource ));
SvTreeListEntry* pEntry = CreateEntry();
- pSource->Clone( pEntry );
- return pSource;
+ pEntry->Clone(pSource);
+ return pEntry;
}
SvTreeListEntry* SvTreeList::CreateEntry() const