summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2020-03-12 10:30:21 +0000
committerMiklos Vajna <vmiklos@collabora.com>2020-03-17 11:27:10 +0100
commita352d0038edd971afdd5d835a8ff548a5f67c389 (patch)
tree2207518e13b567a6f5d305a01915116e38b4ed2d
parent62c45dfbbee1c43aebaa020b5aa18f1271fd0ea1 (diff)
Resolves: tdf#126366 revert use of SfxDispatcher::Lock
Revert "tdf#121607 defer other requests until password dialog is dismissed" This reverts commit 205aeffda1a29865576fb865f23dfb6761ebfab1 as far as I can see the original problem doesn't reappear anyway Change-Id: If5fd3383f3473662bc87a367fad2c1febe1c6a23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90388 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
-rw-r--r--sw/source/uibase/app/apphdl.cxx21
1 files changed, 0 insertions, 21 deletions
diff --git a/sw/source/uibase/app/apphdl.cxx b/sw/source/uibase/app/apphdl.cxx
index a2a2ff35b455..0465bf430e78 100644
--- a/sw/source/uibase/app/apphdl.cxx
+++ b/sw/source/uibase/app/apphdl.cxx
@@ -203,27 +203,9 @@ void SwModule::StateOther(SfxItemSet &rSet)
{
SwView* pView = ::GetActiveView();
std::shared_ptr<SwMailMergeConfigItem> xConfigItem;
- bool bUnLockDispatcher = false;
- SfxDispatcher* pDispatcher = nullptr;
if (pView)
- {
xConfigItem = pView->EnsureMailMergeConfigItem();
- // tdf#121607 lock the dispatcher while processing
- // this request, and release it afterwards,
- // that means that if this request pops up a dialog
- // any other pending requests will be deferred
- // until this request is finished, i.e. they won't
- // be dispatched by the dispatcher timeout until
- // unlock is called, serializing the password dialogs
- pDispatcher = pView->GetViewFrame()->GetDispatcher();
- if (!pDispatcher->IsLocked())
- {
- pDispatcher->Lock(true);
- bUnLockDispatcher = true;
- }
- }
-
// #i51949# hide e-Mail option if e-Mail is not supported
// #i63267# printing might be disabled
if (!xConfigItem ||
@@ -237,9 +219,6 @@ void SwModule::StateOther(SfxItemSet &rSet)
{
rSet.DisableItem(nWhich);
}
-
- if (bUnLockDispatcher)
- pDispatcher->Lock(false);
}
break;
default: