summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>2019-06-06 17:14:53 +0900
committerTor Lillqvist <tml@collabora.com>2019-06-07 10:35:46 +0200
commita4ec8b5d3df1d78b0288c06109887490c74801ba (patch)
tree911cef278bcc8e350d4edd6596a0ab73d09aa238
parent4ee87f7db939f5ea56d5c4d5420450974e8ef601 (diff)
tdf#124947 fix hit area of the radio buttons, size in ios theme
The hit area of the radio buttons was not calculated correctly, so sometimes when you hit the radio button at the "wrong" place, nothing happened. This fixes the hit area to correctly cover the radio button and the text. Another issue was that the ios theme size of the radio button was not defined correctly (32px instead of 26px), which increased the error when calculating the hit are even more. The height of the radio button should be the same as defined in the definition.xml, and not bigger (or smaller). Change-Id: I4b03f36ca9d9c82bd6dc442bd6e06af938c62bdd Reviewed-on: https://gerrit.libreoffice.org/73592 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73593 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
-rw-r--r--vcl/source/control/button.cxx1
-rw-r--r--vcl/uiconfig/theme_definitions/ios/definition.xml2
2 files changed, 2 insertions, 1 deletions
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index f2a909dd753f..1f4a049b6c60 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -2056,6 +2056,7 @@ void RadioButton::ImplDraw( OutputDevice* pDev, DrawFlags nDrawFlags,
rMouseRect = tools::Rectangle( aPos, aSize );
rMouseRect.Left() = rPos.X();
+ rMouseRect.Top() = rPos.Y();
rStateRect.Left() = rPos.X();
rStateRect.Top() = rMouseRect.Top();
diff --git a/vcl/uiconfig/theme_definitions/ios/definition.xml b/vcl/uiconfig/theme_definitions/ios/definition.xml
index 61d6aa21578e..b0e26f01079c 100644
--- a/vcl/uiconfig/theme_definitions/ios/definition.xml
+++ b/vcl/uiconfig/theme_definitions/ios/definition.xml
@@ -85,7 +85,7 @@
</pushbutton>
<radiobutton>
- <part value="Entire" width="32" height="32">
+ <part value="Entire" width="26" height="26">
<state enabled="true" pressed="false" button-value="true">
<image source="tick-on.svg" />
</state>