summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Mohrhard <markus.mohrhard@collabora.co.uk>2015-02-18 19:53:36 +0100
committerAndras Timar <andras.timar@collabora.com>2015-02-19 10:29:45 +0100
commitde6afbecc1220fef01ed33c5db5cdc6ba47c9583 (patch)
tree0b029e34cf1619be8175af57d01f0a60a8cf8384
parent7edd532c989a71744b277752c9bef0b5872024be (diff)
start documenting problems around OOXML spec
We implement in many places wrong default values based on how MSO 2007 behaves. Newer MSO versions produce correct files so our import is wrong. Instead of changing the default value we need to be able to use default values based on the document producer. Change-Id: I6a2a0b30885ebccc384d17f896709ecdd475d786 (cherry picked from commit ffc0391e2e9d797ef8ce3d1089e8d9d2b11a5ead)
-rw-r--r--oox/README9
-rw-r--r--oox/source/drawingml/chart/chartspacemodel.cxx2
2 files changed, 10 insertions, 1 deletions
diff --git a/oox/README b/oox/README
index a25307930259..22a3c3a1d281 100644
--- a/oox/README
+++ b/oox/README
@@ -3,6 +3,15 @@ Support for Office Open XML, the office XML-format designed by Microsoft.
See also:
[http://wiki.openoffice.org/wiki/OOX]
+
+The "TODO: OOXML_spec" comments are related to wrong implementation of the spec. The oox code was
+written against the OOXML dialect produced by MSO 2007,
+which is not standard compliant. Newer MSO version use the correct
+default values as desribed in the spec. We need a way to handle both in the future.
+The first step is to mark these places when you see them. Many of them
+already have a comment that the implemented default value is not
+in line with the spec.
+
== DrawingML Custom shapes and presets ==
custom shapes are part of DrawingML and are different to binary ppt
diff --git a/oox/source/drawingml/chart/chartspacemodel.cxx b/oox/source/drawingml/chart/chartspacemodel.cxx
index 7bf4793e34bc..d36a2f282b57 100644
--- a/oox/source/drawingml/chart/chartspacemodel.cxx
+++ b/oox/source/drawingml/chart/chartspacemodel.cxx
@@ -26,7 +26,7 @@ namespace chart {
// ============================================================================
ChartSpaceModel::ChartSpaceModel() :
- mnDispBlanksAs( XML_gap ), // not zero as specified
+ mnDispBlanksAs( XML_gap ), // not zero as specified, TODO: OOXML_spec
mnStyle( 2 ),
mbAutoTitleDel( false ),
mbPlotVisOnly( false ),