From 2e92313dba4be340a9d97f5b85599a3d4b860d2f Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Mon, 28 Nov 2016 13:48:16 +0100 Subject: gstutils: Fix a pad leak When requesting a pad from a template and it's already linked, this means it was a static pad. Since we only want to return an *available* pad, we must return NULL ... but we must also remove the reference we got from getting that static pad. The "No need to unref" message (which wasn't true for quite some time) dates back from the very very very first commit introducing the 0.10 features. --- gst/gstutils.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gst/gstutils.c b/gst/gstutils.c index e1265a09ff..e64b41fba0 100644 --- a/gst/gstutils.c +++ b/gst/gstutils.c @@ -909,10 +909,11 @@ gst_element_request_compatible_pad (GstElement * element, templ_new = gst_element_get_compatible_pad_template (element, templ); if (templ_new) pad = gst_element_get_pad_from_template (element, templ_new); - - /* This can happen for non-request pads. No need to unref. */ - if (pad && GST_PAD_PEER (pad)) + /* This can happen for non-request pads. */ + if (pad && GST_PAD_PEER (pad)) { + gst_object_unref (pad); pad = NULL; + } return pad; } -- cgit v1.2.3