diff options
| author | Daniel van Vugt <daniel.van.vugt@canonical.com> | 2017-11-02 13:21:34 +0100 |
|---|---|---|
| committer | Víctor Manuel Jáquez Leal <vjaquez@igalia.com> | 2017-11-06 18:00:14 +0100 |
| commit | e1f9959eb51085d241f5e57fc235422126023375 (patch) | |
| tree | bd0e3423a0d31747cce9e42a3f6c297a451fa39c /gst-libs | |
| parent | 429e8002047e341136f834d44dc2a21b4af41dba (diff) | |
libs: surface: egl: add comment
Add a warning comment when using old intel-vaapi-drivers (>1.8.4),
where the creation of surfaces from GEM fd may fail.
https://bugzilla.gnome.org/show_bug.cgi?id=773453
Diffstat (limited to 'gst-libs')
| -rw-r--r-- | gst-libs/gst/vaapi/gstvaapisurface_egl.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/gst-libs/gst/vaapi/gstvaapisurface_egl.c b/gst-libs/gst/vaapi/gstvaapisurface_egl.c index 8bc42e53..8ebd8018 100644 --- a/gst-libs/gst/vaapi/gstvaapisurface_egl.c +++ b/gst-libs/gst/vaapi/gstvaapisurface_egl.c @@ -64,6 +64,16 @@ do_create_surface_with_egl_image_unlocked (GstVaapiDisplayEGL * display, goto error_export_image_gem_buf; size = height * stride[0]; + /* + * XXX: The below surface creation may fail on Intel due to: + * https://github.com/01org/intel-vaapi-driver/issues/222 + * A permanent fix for that problem will be released in intel-vaapi-driver + * version 1.8.4 and later, and also in 1.8.3-1ubuntu1. + * However if you don't have that fix then a simple workaround is to + * uncomment this line of code: + * size = GST_ROUND_UP_32 (height) * stride[0]; + */ + return gst_vaapi_surface_new_with_gem_buf_handle (base_display, name, size, format, width, height, offset, stride); |