From 868a885040f10f10782860031b7798d6f255a8b1 Mon Sep 17 00:00:00 2001 From: Vineeth TM Date: Tue, 21 Jul 2015 12:44:55 +0900 Subject: rmdemux: fix wrong unref when there are no tags Tags should be appended to pending tags and unref'ed only if tags are present. Else there is no need to append. https://bugzilla.gnome.org/show_bug.cgi?id=752404 --- gst/realmedia/rmdemux.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gst/realmedia/rmdemux.c b/gst/realmedia/rmdemux.c index 08b798bf..f170b213 100644 --- a/gst/realmedia/rmdemux.c +++ b/gst/realmedia/rmdemux.c @@ -1929,11 +1929,13 @@ gst_rmdemux_parse_cont (GstRMDemux * rmdemux, const guint8 * data, int length) tags = gst_rm_utils_read_tags (data, length, gst_rm_utils_read_string16); - GST_LOG_OBJECT (rmdemux, "tags: %" GST_PTR_FORMAT, tags); + if (tags) { + GST_LOG_OBJECT (rmdemux, "tags: %" GST_PTR_FORMAT, tags); - rmdemux->pending_tags = - gst_tag_list_merge (rmdemux->pending_tags, tags, GST_TAG_MERGE_APPEND); - gst_tag_list_unref (tags); + rmdemux->pending_tags = + gst_tag_list_merge (rmdemux->pending_tags, tags, GST_TAG_MERGE_APPEND); + gst_tag_list_unref (tags); + } } static void -- cgit v1.2.3