From 15440f2ddc76faf61a7cdbc72e7b34f69b497415 Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Thu, 2 Apr 2020 16:18:00 -0400 Subject: x264enc: Fix 'ref' property range and default The --ref option indicate the size of the DPB, hence should be in the range of 0 to 16. This patch also fix the default to match x264enc default 3. This change isn't a behaviour change since we don't enforce the reported default. --- ext/x264/gstx264enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/x264/gstx264enc.c b/ext/x264/gstx264enc.c index ef1c28f2..961840eb 100644 --- a/ext/x264/gstx264enc.c +++ b/ext/x264/gstx264enc.c @@ -409,7 +409,7 @@ enum #define ARG_SUBME_DEFAULT 1 #define ARG_ANALYSE_DEFAULT 0 #define ARG_DCT8x8_DEFAULT FALSE -#define ARG_REF_DEFAULT 1 +#define ARG_REF_DEFAULT 3 #define ARG_BFRAMES_DEFAULT 0 #define ARG_B_ADAPT_DEFAULT TRUE #define ARG_B_PYRAMID_DEFAULT FALSE @@ -1073,7 +1073,7 @@ gst_x264_enc_class_init (GstX264EncClass * klass) g_object_class_install_property (gobject_class, ARG_REF, g_param_spec_uint ("ref", "Reference Frames", "Number of reference frames", - 1, 12, ARG_REF_DEFAULT, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); + 1, 16, ARG_REF_DEFAULT, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); g_string_append_printf (x264enc_defaults, ":ref=%d", ARG_REF_DEFAULT); g_object_class_install_property (gobject_class, ARG_BFRAMES, g_param_spec_uint ("bframes", "B-Frames", -- cgit v1.2.3