diff options
author | Sebastian Dröge <sebastian@centricular.com> | 2020-08-21 10:35:11 +0300 |
---|---|---|
committer | Tim-Philipp Müller <tim@centricular.com> | 2020-08-24 23:23:43 +0100 |
commit | 60337ffed99e173d58c4f4f6cd084df7e00c527d (patch) | |
tree | a4edd0628c53bc16fc578073d1d3b00ba55673db | |
parent | bb76cbd5ae78658318f74cb2cf52b24929da1cca (diff) |
x264enc: Allow maximum quantizer value of 63 instead of 51
QP_MAX_SPEC in x264 is set to 63 nowadays and in theory it allows even
up to 81 (QP_MAX) but that seems to be outside the spec.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-ugly/-/merge_requests/67>
-rw-r--r-- | docs/gst_plugins_cache.json | 6 | ||||
-rw-r--r-- | ext/x264/gstx264enc.c | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/docs/gst_plugins_cache.json b/docs/gst_plugins_cache.json index 304fbcf1..fb6d824d 100644 --- a/docs/gst_plugins_cache.json +++ b/docs/gst_plugins_cache.json @@ -1504,7 +1504,7 @@ "construct-only": false, "controllable": false, "default": "51", - "max": "51", + "max": "63", "min": "0", "mutable": "null", "readable": true, @@ -1518,7 +1518,7 @@ "construct-only": false, "controllable": false, "default": "10", - "max": "51", + "max": "63", "min": "0", "mutable": "null", "readable": true, @@ -1532,7 +1532,7 @@ "construct-only": false, "controllable": false, "default": "4", - "max": "50", + "max": "63", "min": "0", "mutable": "null", "readable": true, diff --git a/ext/x264/gstx264enc.c b/ext/x264/gstx264enc.c index c6248fe2..44901813 100644 --- a/ext/x264/gstx264enc.c +++ b/ext/x264/gstx264enc.c @@ -1137,18 +1137,18 @@ gst_x264_enc_class_init (GstX264EncClass * klass) g_string_append_printf (x264enc_defaults, ":cabac=%d", ARG_CABAC_DEFAULT); g_object_class_install_property (gobject_class, ARG_QP_MIN, g_param_spec_uint ("qp-min", "Minimum Quantizer", - "Minimum quantizer", 0, 51, ARG_QP_MIN_DEFAULT, + "Minimum quantizer", 0, 63, ARG_QP_MIN_DEFAULT, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); g_string_append_printf (x264enc_defaults, ":qpmin=%d", ARG_QP_MIN_DEFAULT); g_object_class_install_property (gobject_class, ARG_QP_MAX, g_param_spec_uint ("qp-max", "Maximum Quantizer", - "Maximum quantizer", 0, 51, ARG_QP_MAX_DEFAULT, + "Maximum quantizer", 0, 63, ARG_QP_MAX_DEFAULT, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); g_string_append_printf (x264enc_defaults, ":qpmax=%d", ARG_QP_MAX_DEFAULT); g_object_class_install_property (gobject_class, ARG_QP_STEP, g_param_spec_uint ("qp-step", "Maximum Quantizer Difference", "Maximum quantizer difference between frames", - 0, 50, ARG_QP_STEP_DEFAULT, + 0, 63, ARG_QP_STEP_DEFAULT, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); g_string_append_printf (x264enc_defaults, ":qpstep=%d", ARG_QP_STEP_DEFAULT); g_object_class_install_property (gobject_class, ARG_IP_FACTOR, |