Release 1.18.41.18.4

6 files changed, 329 insertions, 12 deletions

diff --git a/ChangeLog b/ChangeLog
index b1dd86177..86bdde110 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,147 @@
+=== release 1.18.4 ===
+
+2021-03-15 17:48:28 +0000  Tim-Philipp Müller <tim@centricular.com>
+
+	* ChangeLog:
+	* NEWS:
+	* RELEASE:
+	* gst-plugins-good.doap:
+	* meson.build:
+	  Release 1.18.4
+
+2021-03-04 13:05:19 +0200  Sebastian Dröge <sebastian@centricular.com>
+
+	* gst/matroska/matroska-demux.c:
+	* gst/matroska/matroska-ids.h:
+	  matroskademux: Fix extraction of multichannel WavPack
+	  The old code had a couple of issues that all lead to potential memory
+	  safety bugs.
+	  - Use a constant for the Wavpack4Header size instead of using sizeof.
+	  It's written out into the data and not from the struct and who knows
+	  what special alignment/padding requirements some C compilers have.
+	  - gst_buffer_set_size() does not realloc the buffer when setting a
+	  bigger size than allocated, it only allows growing up to the maximum
+	  allocated size. Instead use a GstAdapter to collect all the blocks
+	  and take out everything at once in the end.
+	  - Check that enough data is actually available in the input and
+	  otherwise handle it an error in all cases instead of silently
+	  ignoring it.
+	  Among other things this fixes out of bounds writes because the code
+	  assumed gst_buffer_set_size() can grow the buffer and simply wrote after
+	  the end of the buffer.
+	  Thanks to Natalie Silvanovich for reporting.
+	  Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/859
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/903>
+
+2021-03-03 11:31:52 +0200  Sebastian Dröge <sebastian@centricular.com>
+
+	* gst/matroska/matroska-demux.c:
+	  matroskademux: Initialize track context out parameter to NULL before parsing
+	  Various error return paths don't set it to NULL and callers are only
+	  checking if the pointer is NULL. As it's allocated on the stack this
+	  usually contains random stack memory, and more often than not the memory
+	  of a previously parsed track.
+	  This then causes all kinds of memory corruptions further down the line.
+	  Thanks to Natalie Silvanovich for reporting.
+	  Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/858
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/903>
+
+2021-01-18 15:54:43 +0100  Philipp Zabel <p.zabel@pengutronix.de>
+
+	* sys/v4l2/gstv4l2object.c:
+	  v4l2object: handle GST_VIDEO_TRANSFER_BT601
+	  V4L2 makes no difference between the BT.601 and BT.709 transfer
+	  functions [1], but GStreamer does since 1.18 [2].
+	  Adapt gst_v4l2_object_get_colorspace() and
+	  gst_v4l2_object_set_format_full().
+	  [1] https://linuxtv.org/downloads/v4l-dvb-apis-new/userspace-api/v4l/colorspaces-details.html#colorspace-smpte-170m-v4l2-colorspace-smpte170m
+	  [2] https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/724
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/900>
+
+2021-03-07 21:25:01 +0000  Vladimir Menshakov <vladimir.menshakov@gmail.com>
+
+	* docs/gst_plugins_cache.json:
+	* ext/wavpack/gstwavpackdec.c:
+	* ext/wavpack/gstwavpackdec.h:
+	  wavpackdec: Add floating point format support
+	  This commit negotiate F32 audio format if MODE_FLOAT used in wavpack file.
+	  Wavpack float mode is always in 32-bit IEEE format.
+	  The following pipeline plays distorted audio if source file is encoded in float mode:
+	  gst-launch-1.0 filesrc ... ! wavpackparse ! wavpackdec ! pulsesink
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/896>
+
+2021-03-01 14:32:40 +0800  Hou Qi <qi.hou@nxp.com>
+
+	* sys/v4l2/gstv4l2videodec.c:
+	  v4l2videodec: Do not expose profiles/levels in vp8/vp9 template caps
+	  Vp8/vp9 supported profiles/levels are listed in decoder sink caps, but
+	  there is no parser for these two formats and the demuxers also don't have
+	  these information. It causes negotiation fail between demuxers and decoder
+	  when check caps "accept = gst_caps_is_subset (caps, template_caps);".
+	  To fix this, need to remove profiles/levels for vp8/vp9 formats in decoder
+	  sink caps.
+	  Fix #854
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/890>
+
+2021-02-24 13:25:43 +0100  Philipp Zabel <p.zabel@pengutronix.de>
+
+	* sys/v4l2/gstv4l2videodec.c:
+	  v4l2videodec: fix src side frame rate negotiation
+	  Negotiating v4l2h264dec ! v4l2h264enc transcoding pipelines fails in
+	  case the encoder does not accept framerate=(fraction)0/1.
+	  The acquired caps used for downstream negotiation are determined from
+	  gst_v4l2_object_acquire_format(), which sets the GstVideoInfo::fps_n
+	  and ::fps_d fields to 0.
+	  To fix this, copy the frame rate from the sink side.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/884>
+
+2021-02-16 16:20:05 +0200  Jordan Petridis <jpetridis@gnome.org>
+
+	* sys/rpicamsrc/meson.build:
+	  rpicamsrc: depend on posix threads and vchiq_arm
+	  Could only test on rpi 3b+
+	  Close #839
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/883>
+
+2021-02-16 22:20:17 +1100  Ashley Brighthope <ashley.b@reddegrees.com>
+
+	* gst/wavenc/gstwavenc.c:
+	  wavenc: Fixed INFO chunk corruption, caused by odd sized data not being padded. Code style was updated.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/877>
+
+2021-02-04 13:43:17 +0800  Bing Song <bing.song@nxp.com>
+
+	* sys/v4l2/gstv4l2videoenc.c:
+	  v4l2videoenc: support resolution change stream encode.
+	  Resolution change stream transcoding will drain before send new video
+	  frame buffer. Need encode video frame after process EOS.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/872>
+
+2021-01-14 01:12:06 +0800  Bing Song <bing.song@nxp.com>
+
+	* sys/v4l2/gstv4l2h265codec.c:
+	  v4l2h265codec: fix HEVC profile string issue.
+	  Keep HEVC profile compatible with other module.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/864>
+
+2020-12-15 10:41:40 +0800  Bing Song <bing.song@nxp.com>
+
+	* sys/v4l2/gstv4l2object.c:
+	* sys/v4l2/gstv4l2object.h:
+	  v4l2object: Need keep same transfer as input caps.
+	  GST_VIDEO_TRANSFER_BT2020_12 and GST_VIDEO_TRANSFER_BT2020_10 will
+	  be mapped to V4L2_XFER_FUNC_709. Need check input caps when map
+	  V4L2_XFER_FUNC_709 back to GST_VIDEO_TRANSFER_BT2020_12 and
+	  GST_VIDEO_TRANSFER_BT2020_10
+	  Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/816
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/861>
+
+2021-01-14 02:17:10 +0000  Tim-Philipp Müller <tim@centricular.com>
+
+	* docs/gst_plugins_cache.json:
+	* meson.build:
+	  Back to development
+
 === release 1.18.3 ===
 
 2021-01-13 21:08:50 +0000  Tim-Philipp Müller <tim@centricular.com>
@@ -5,6 +149,7 @@
 	* ChangeLog:
 	* NEWS:
 	* RELEASE:
+	* docs/gst_plugins_cache.json:
 	* gst-plugins-good.doap:
 	* meson.build:
 	  Release 1.18.3
diff --git a/NEWS b/NEWS
index 1ac82bdf4..3ada8869c 100644
--- a/NEWS
+++ b/NEWS
@@ -2,13 +2,13 @@ GStreamer 1.18 Release Notes
 
 GStreamer 1.18.0 was originally released on 8 September 2020.
 
-The latest bug-fix release in the 1.18 series is 1.18.3 and was released
-on 13 January 2021.
+The latest bug-fix release in the 1.18 series is 1.18.4 and was released
+on 15 March 2021.
 
 See https://gstreamer.freedesktop.org/releases/1.18/ for the latest
 version of this document.
 
-Last updated: Wednesday 13 January 2021, 20:00 UTC (log)
+Last updated: Monday 15 March 2021, 13:00 UTC (log)
 
 Introduction
 
@@ -2717,6 +2717,168 @@ List of merge requests and issues fixed in 1.18.3
 -   List of Merge Requests applied in 1.18.3
 -   List of Issues fixed in 1.18.3
 
+1.18.4
+
+The fourth 1.18 bug-fix release (1.18.4) was released on 15 March 2021.
+
+This release only contains bugfixes and security fixes and it should be
+safe to update from 1.18.x.
+
+Highlighted bugfixes in 1.18.4
+
+-   important security fixes for ID3 tag reading, matroska and realmedia
+    parsing, and gst-libav audio decoding
+-   audiomixer, audioaggregator: input buffer handling fixes
+-   decodebin3: improve stream-selection message handling
+-   uridecodebin3: make “caps” property work
+-   wavenc: fix writing of INFO chunks in some cases
+-   v4l2: bt601 colorimetry, allow encoder resolution changes, fix
+    decoder frame rate negotiation
+-   decklinkvideosink: fix auto format detection, and fixes for 29.97fps
+    framerate output
+-   mpeg-2 video handling fixes when seeking
+-   avviddec: fix bufferpool negotiation and possible memory corruption
+    when changing resolution
+-   various stability, performance and reliability improvements
+-   memory leak fixes
+-   build fixes: rpicamsrc, qt overlay example, d3d11videosink on UWP
+
+gstreamer
+
+-   info: Don’t leak log function user_data if the debug system is
+    compiled out
+-   task: Use SetThreadDescription() Win32 API for setting thread names,
+    which preserves thread names in dump files.
+-   buffer, memory: Mark info in map functions as caller-allocates and
+    pass allocation params as const pointers where possible
+-   clock: define AUTO_CLEANUP_FREE_FUNC for GstClockID
+
+gst-plugins-base
+
+-   tag: id3v2: fix frame size check and potential invalid reads
+-   audio: Fix gst_audio_buffer_truncate() meta handling for
+    non-interleaved audio
+-   audioresample: respect buffer layout when draining
+-   audioaggregator: fix input_buffer ownership
+-   decodebin3: change stream selection message owner, so that the app
+    sends the stream-selection event to the right element
+-   rtspconnection: correct data_size when tunneled mode
+-   uridecodebin3: make caps property work
+-   video-converter: Don’t upsample invalid lines
+-   videodecoder: Fix racy critical when pool negotiation occurs during
+    flush
+-   video: Convert gst_video_info_to_caps() to take self as const ptr
+-   examples: added qt core dependency for qt overlay example
+
+gst-plugins-good
+
+-   matroskademux: header parsing fixes
+-   rpicamsrc: depend on posix threads and vchiq_arm to fix build on
+    raspios again
+-   wavenc: Fixed INFO chunk corruption, caused by odd sized data not
+    being padded
+-   wavpackdec: Add floating point format support to fix distortions in
+    some cases
+-   v4l2: recognize V4L2 bt601 colorimetry again
+-   v4l2videoenc: support resolution change stream encode
+-   v4l2h265codec: fix HEVC profile string issue
+-   v4l2object: Need keep same transfer as input caps
+-   v4l2videodec: Fix vp8 and vp9 streams can’t play on board with
+    vendor bsp
+-   v4l2videodec: fix src side frame rate negotiation
+
+gst-plugins-bad
+
+-   avwait: Don’t post messages with the mutex locked
+-   d3d11h264dec: Reconfigure decoder object on DPB size change and keep
+    track of actually configured DPB size
+-   dashsink: fix double unref of sinkpad caps
+-   decklinkvideosink: Use correct numerator for 29.97fps
+-   decklinkvideosink: fix auto format detection
+-   decklinksrc: Use a more accurate capture time
+-   d3d11videosink: Fix build error on UWP
+-   interlace: negotiation and buffer leak fixes
+-   mpegvideoparse: do not clip, so decoder receives data from keyframe
+    even if it’s before the segment start
+-   mpegtsparse: Fix switched DTS/PTS when set-timestamps=false
+-   nvh264sldec: Reopen decoder object if larger DPB size is required
+-   sdpsrc: fix double free if sdp is provided as string via the
+    property
+-   vulkan: Fix elements long name.
+
+gst-plugins-ugly
+
+-   rmdemux: Make sure we have enough data available when parsing
+    audio/video packets
+
+gst-libav
+
+-   avviddec: take the maximum of the height/coded_height
+-   viddec: don’t configure an incorrect buffer pool when receiving a
+    gap event
+-   audiodec: fix stack overflow in gst_ffmpeg_channel_layout_to_gst()
+
+gst-rtsp-server
+
+-   rtspclientsink: fix deadlock on shutdown if no data has been
+    received yet
+-   rtspclientsink: fix leaks in unit tests
+-   rtsp-stream: avoid deadlock in send_func
+-   rtsp-client: cleanup transports during TEARDOWN
+
+gstreamer-vaapi
+
+-   h264 encoder: append encoder exposure to aud
+-   postproc: Fix a problem of propose_allocation when passthrough
+-   glx: Iterate over FBConfig and select 8 bit color size
+
+gstreamer-sharp
+
+-   no changes
+
+gst-omx
+
+-   no changes
+
+gst-python
+
+-   no changes
+
+gst-editing-services
+
+-   group: Use proper group constructor
+
+gst-integration-testsuites
+
+-   no changes
+
+gst-build
+
+-   no changes
+
+Cerbero build tool and packaging changes in 1.18.4
+
+-   macOS: more BigSur fixes
+-   glib: Backport patch to set thread names on Windows 10
+
+Contributors to 1.18.4
+
+Alicia Boya García, Ashley Brighthope, Bing Song, Branko Subasic, Edward
+Hervey, Guillaume Desmottes, Haihua Hu, He Junyan, Hou Qi, Jan Alexander
+Steffens (heftig), Jeongki Kim, Jordan Petridis, Knobe, Kristofer
+Björkström, Marijn Suijten, Matthew Waters, Paul Goulpié, Philipp Zabel,
+Rafał Dzięgiel, Sebastian Dröge, Seungha Yang, Staz M, Stéphane Cerveau,
+Thibault Saunier, Tim-Philipp Müller, Víctor Manuel Jáquez Leal, Vivia
+Nikolaidou, Vladimir Menshakov,
+
+… and many others who have contributed bug reports, translations, sent
+suggestions or helped testing. Thank you all!
+
+List of merge requests and issues fixed in 1.18.4
+
+-   List of Merge Requests applied in 1.18.4
+-   List of Issues fixed in 1.18.4
+
 Schedule for 1.20
 
 Our next major feature release will be 1.20, and 1.19 will be the
@@ -2724,9 +2886,9 @@ unstable development version leading up to the stable 1.20 release. The
 development of 1.19/1.20 will happen in the git master branch.
 
 The plan for the 1.20 development cycle is yet to be confirmed, but it
-is now expected that feature freeze will take place some time in
-January/February 2021, with the first 1.20 stable release hopefully
-around February/March 2021.
+is now expected that feature freeze will take place some time in April
+2021, with the first 1.20 stable release hopefully around April/May
+2021.
 
 1.20 will be backwards-compatible to the stable 1.18, 1.16, 1.14, 1.12,
 1.10, 1.8, 1.6, 1.4, 1.2 and 1.0 release series.
diff --git a/RELEASE b/RELEASE
index f94078542..ac6e86817 100644
--- a/RELEASE
+++ b/RELEASE
@@ -1,4 +1,4 @@
-This is GStreamer gst-plugins-good 1.18.3.
+This is GStreamer gst-plugins-good 1.18.4.
 
 The GStreamer team is thrilled to announce a new major feature release
 of your favourite cross-platform multimedia framework!
diff --git a/docs/gst_plugins_cache.json b/docs/gst_plugins_cache.json
index 6855495f7..d70b40830 100644
--- a/docs/gst_plugins_cache.json
+++ b/docs/gst_plugins_cache.json
@@ -6595,7 +6595,7 @@
                         "construct": false,
                         "construct-only": false,
                         "controllable": false,
-                        "default": "GStreamer 1.18.3.1 FLV muxer",
+                        "default": "GStreamer 1.18.4 FLV muxer",
                         "mutable": "null",
                         "readable": true,
                         "type": "gchararray",
@@ -6607,7 +6607,7 @@
                         "construct": false,
                         "construct-only": false,
                         "controllable": false,
-                        "default": "GStreamer 1.18.3.1 FLV muxer",
+                        "default": "GStreamer 1.18.4 FLV muxer",
                         "mutable": "null",
                         "readable": true,
                         "type": "gchararray",
@@ -20636,7 +20636,7 @@
                         "construct": false,
                         "construct-only": false,
                         "controllable": false,
-                        "default": "GStreamer/1.18.3.1",
+                        "default": "GStreamer/1.18.4",
                         "mutable": "null",
                         "readable": true,
                         "type": "gchararray",
@@ -22593,7 +22593,7 @@
                         "construct": false,
                         "construct-only": false,
                         "controllable": false,
-                        "default": "GStreamer souphttpsrc 1.18.3.1 ",
+                        "default": "GStreamer souphttpsrc 1.18.4 ",
                         "mutable": "null",
                         "readable": true,
                         "type": "gchararray",
diff --git a/gst-plugins-good.doap b/gst-plugins-good.doap
index 6a6dff467..9defd3189 100644
--- a/gst-plugins-good.doap
+++ b/gst-plugins-good.doap
@@ -34,6 +34,16 @@ the plug-in code, LGPL or LGPL-compatible for the supporting library).
 
  <release>
   <Version>
+   <revision>1.18.4</revision>
+   <branch>1.18</branch>
+   <name></name>
+   <created>2021-03-15</created>
+   <file-release rdf:resource="https://gstreamer.freedesktop.org/src/gst-plugins-good/gst-plugins-good-1.18.4.tar.xz" />
+  </Version>
+ </release>
+
+ <release>
+  <Version>
    <revision>1.18.3</revision>
    <branch>1.18</branch>
    <name></name>
diff --git a/meson.build b/meson.build
index 1db9612e3..9de3b01e3 100644
--- a/meson.build
+++ b/meson.build
@@ -1,5 +1,5 @@
 project('gst-plugins-good', 'c',
-  version : '1.18.3.1',
+  version : '1.18.4',
   meson_version : '>= 0.48',
   default_options : [ 'warning_level=1',
                       'buildtype=debugoptimized' ])