summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>2016-05-19 13:29:15 +0300
committerSebastian Dröge <sebastian@centricular.com>2016-06-21 10:52:47 +0300
commite071510b12404e3875b750141552075dca98fb63 (patch)
tree9735056cb3d00fee6270d0764a9c50b22e2fded2 /tests
parent6a02c8a10927ad0c4dbb6e07b6e4e71923c4d69a (diff)
glimagesink: properly setup/teardown tests
tcase_add_checked_fixture() is suppose to call the setup and teardown functions so the tests don't have to do it manually. https://bugzilla.gnome.org/show_bug.cgi?id=766663
Diffstat (limited to 'tests')
-rw-r--r--tests/check/elements/glimagesink.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/tests/check/elements/glimagesink.c b/tests/check/elements/glimagesink.c
index 07f6899d3..cc32015f5 100644
--- a/tests/check/elements/glimagesink.c
+++ b/tests/check/elements/glimagesink.c
@@ -116,8 +116,6 @@ GST_START_TEST (test_query_drain)
loop = g_main_loop_new (NULL, FALSE);
#endif
- setup_glimagesink ();
-
/* GstBaseSink handles the drain query as well. */
g_object_set (sinkelement, "enable-last-sample", TRUE, NULL);
@@ -210,8 +208,6 @@ GST_START_TEST (test_query_drain)
fail_unless (gst_buffer_pool_set_active (pool, FALSE));
gst_object_unref (pool);
- cleanup_glimagesink ();
-
if (loop)
g_main_loop_unref (loop);
}
@@ -226,7 +222,7 @@ glimagesink_suite (void)
tcase_set_timeout (tc, 5);
- tcase_add_checked_fixture (tc, setup_glimagesink, NULL);
+ tcase_add_checked_fixture (tc, setup_glimagesink, cleanup_glimagesink);
tcase_add_test (tc, test_query_drain);
suite_add_tcase (s, tc);