summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVivia Nikolaidou <vivia@ahiru.eu>2020-06-18 23:52:01 +0300
committerVivia Nikolaidou <vivia@ahiru.eu>2020-06-24 11:31:15 +0300
commitb53c1363f250c051b92d6af1123f21e4300fb117 (patch)
treeaa761ecced411ff6b391b503d7fa9b5f7939a2ce
parent7c7ac7a0dc044d6837b9fc38af8b319970c2b90e (diff)
interlace: Don't change field-pattern on PAUSED or PLAYING state
It would otherwise change the caps the element produces and cause the element to misbehave Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1349>
-rw-r--r--docs/plugins/gst_plugins_cache.json2
-rw-r--r--gst/interlace/gstinterlace.c3
2 files changed, 3 insertions, 2 deletions
diff --git a/docs/plugins/gst_plugins_cache.json b/docs/plugins/gst_plugins_cache.json
index 41c48f782..6e78adf94 100644
--- a/docs/plugins/gst_plugins_cache.json
+++ b/docs/plugins/gst_plugins_cache.json
@@ -23768,7 +23768,7 @@
"construct-only": false,
"controllable": false,
"default": "2:3 (2)",
- "mutable": "null",
+ "mutable": "ready",
"readable": true,
"type": "GstInterlacePattern",
"writable": true
diff --git a/gst/interlace/gstinterlace.c b/gst/interlace/gstinterlace.c
index f84b2eb4a..efe4e0b88 100644
--- a/gst/interlace/gstinterlace.c
+++ b/gst/interlace/gstinterlace.c
@@ -240,7 +240,8 @@ gst_interlace_class_init (GstInterlaceClass * klass)
g_param_spec_enum ("field-pattern", "Field pattern",
"The output field pattern", GST_INTERLACE_PATTERN,
GST_INTERLACE_PATTERN_2_3,
- G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
+ GST_PARAM_MUTABLE_READY | G_PARAM_READWRITE |
+ G_PARAM_STATIC_STRINGS));
g_object_class_install_property (object_class, PROP_PATTERN_OFFSET,
g_param_spec_uint ("pattern-offset", "Pattern offset",