From 6980775bcadec862cd5e5affd65928ef79e5b580 Mon Sep 17 00:00:00 2001 From: Arkadiusz Hiler Date: Thu, 23 Jul 2020 14:16:15 +0300 Subject: tests/i915_pm_lpsp: Fix compilation warning ... and make the test do what it claims to be doing. The test needs all outputs to be disabled, but it was iterating with for_each_pipe_with_single_output, which iterates over pipes and tries to match them with some output. This may lead to us not iterating over all the outputs in some circumstances. Cc: Anshuman Gupta Signed-off-by: Arkadiusz Hiler Reviewed-by: Anshuman Gupta Reviewed-by: Petri Latvala --- tests/i915/i915_pm_lpsp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c index e9a593070..4a1878109 100644 --- a/tests/i915/i915_pm_lpsp.c +++ b/tests/i915/i915_pm_lpsp.c @@ -82,12 +82,10 @@ static bool dmc_supported(int debugfs) */ static void screens_disabled_subtest(data_t *data) { - igt_output_t *output; int valid_output = 0; - enum pipe pipe; - for_each_pipe_with_single_output(&data->display, pipe, output) { - data->output = output; + for (int i = 0; i < data->display.n_outputs; i++) { + data->output = &data->display.outputs[i]; igt_output_set_pipe(data->output, PIPE_NONE); igt_display_commit(&data->display); valid_output++; -- cgit v1.2.3