path: root/samples
diff options
authorLeo Yan <>2019-07-02 18:25:31 +0800
committerDaniel Borkmann <>2019-07-03 12:17:29 +0200
commit33bae185f74d49a0d7b1bfaafb8e959efce0f243 (patch)
tree267fab5843b79dcbc9dde80e5038f9b55334b8a2 /samples
parentcdfc7f888c2a355b01308e97c6df108f1c2b64e8 (diff)
bpf, libbpf, smatch: Fix potential NULL pointer dereference
Based on the following report from Smatch, fix the potential NULL pointer dereference check: tools/lib/bpf/libbpf.c:3493 bpf_prog_load_xattr() warn: variable dereferenced before check 'attr' (see line 3483) 3479 int bpf_prog_load_xattr(const struct bpf_prog_load_attr *attr, 3480 struct bpf_object **pobj, int *prog_fd) 3481 { 3482 struct bpf_object_open_attr open_attr = { 3483 .file = attr->file, 3484 .prog_type = attr->prog_type, ^^^^^^ 3485 }; At the head of function, it directly access 'attr' without checking if it's NULL pointer. This patch moves the values assignment after validating 'attr' and 'attr->file'. Signed-off-by: Leo Yan <> Acked-by: Yonghong Song <> Signed-off-by: Daniel Borkmann <>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions