path: root/drivers/gpu
diff options
authorPaul Cercueil <>2020-05-16 23:50:50 +0200
committerPaul Cercueil <>2020-05-17 14:16:15 +0200
commitabf56fadf0e208abfb13ad1ac0094416058da0ad (patch)
tree5501a3c52e0b77854f613ae426a407bef8d50a59 /drivers/gpu
parenta53bcc19876498bdd3b4ef796c787295dcc498b4 (diff)
gpu/drm: Ingenic: Fix opaque pointer casted to wrong type
The opaque pointer passed to the IRQ handler is a pointer to the drm_device, not a pointer to our ingenic_drm structure. It still worked, because our ingenic_drm structure contains the drm_device as its first field, so the pointer received had the same value, but this was not semantically correct. Cc: # v5.3 Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs") Signed-off-by: Paul Cercueil <> Link: Acked-by: Sam Ravnborg <>
Diffstat (limited to 'drivers/gpu')
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c
index a5ad6a4353e1..548cc25ea4ab 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
@@ -474,7 +474,7 @@ static int ingenic_drm_encoder_atomic_check(struct drm_encoder *encoder,
static irqreturn_t ingenic_drm_irq_handler(int irq, void *arg)
- struct ingenic_drm *priv = arg;
+ struct ingenic_drm *priv = drm_device_get_priv(arg);
unsigned int state;
regmap_read(priv->map, JZ_REG_LCD_STATE, &state);