diff options
| author | Xie Yongji <xieyongji@bytedance.com> | 2021-05-17 16:49:11 +0800 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2021-05-18 10:55:30 +0200 |
| commit | 17f46f488a5d82c5568e6e786cd760bba1c2ee09 (patch) | |
| tree | c9feb1f7cfe1e7fd09085c1c15c0229130753d57 /drivers/gpu/drm/virtio | |
| parent | 644adc3d0ff05f49fae9a7549e27dfd7e9a5afe5 (diff) | |
drm/virtio: Fixes a potential NULL pointer dereference on probe failure
The dev->dev_private might not be allocated if virtio_gpu_pci_quirk()
or virtio_gpu_init() failed. In this case, we should avoid the cleanup
in virtio_gpu_release().
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20210517084913.403-1-xieyongji@bytedance.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/virtio')
| -rw-r--r-- | drivers/gpu/drm/virtio/virtgpu_kms.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/virtgpu_kms.c index b375394193be..aa532ad31a23 100644 --- a/drivers/gpu/drm/virtio/virtgpu_kms.c +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c @@ -264,6 +264,9 @@ void virtio_gpu_release(struct drm_device *dev) { struct virtio_gpu_device *vgdev = dev->dev_private; + if (!vgdev) + return; + virtio_gpu_modeset_fini(vgdev); virtio_gpu_free_vbufs(vgdev); virtio_gpu_cleanup_cap_cache(vgdev); |