path: root/drivers/gpu/drm/amd/amdkfd
diff options
authorOdin Ugedal <>2020-04-03 19:55:28 +0200
committerTejun Heo <>2020-04-13 14:41:54 -0400
commiteec8fd0277e37cf447b88c6be181e81df867bcf1 (patch)
tree0110a5197275738dfd1d82cabecf277b521eac26 /drivers/gpu/drm/amd/amdkfd
parent772b3140669246e1ab32392c490d338e2eb7b803 (diff)
device_cgroup: Cleanup cgroup eBPF device filter code
Original cgroup v2 eBPF code for filtering device access made it possible to compile with CONFIG_CGROUP_DEVICE=n and still use the eBPF filtering. Change commit 4b7d4d453fc4 ("device_cgroup: Export devcgroup_check_permission") reverted this, making it required to set it to y. Since the device filtering (and all the docs) for cgroup v2 is no longer a "device controller" like it was in v1, someone might compile their kernel with CONFIG_CGROUP_DEVICE=n. Then (for linux 5.5+) the eBPF filter will not be invoked, and all processes will be allowed access to all devices, no matter what the eBPF filter says. Signed-off-by: Odin Ugedal <> Acked-by: Roman Gushchin <> Signed-off-by: Tejun Heo <>
Diffstat (limited to 'drivers/gpu/drm/amd/amdkfd')
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
index 4a3049841086..c24cad3c64ed 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
@@ -1050,7 +1050,7 @@ void kfd_dec_compute_active(struct kfd_dev *dev);
/* Check with device cgroup if @kfd device is accessible */
static inline int kfd_devcgroup_check_permission(struct kfd_dev *kfd)
struct drm_device *ddev = kfd->ddev;
return devcgroup_check_permission(DEVCG_DEV_CHAR, ddev->driver->major,