diff options
| author | Dave Airlie <airlied@redhat.com> | 2023-02-23 09:47:29 +1000 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2023-02-23 09:48:05 +1000 |
| commit | a48bba98380cb0b43dcd01d276c7efc282e3c33f (patch) | |
| tree | 2937b3cb4bb62e7b12034bb40bb14cb8646f62c2 | |
| parent | 13daf536191e8c484fa21de8fcac4767f7b66e80 (diff) | |
msm/fbdev: fix unused variable warning with clang.drm-next-2023-02-23
clang builds showed this:
drivers/gpu/drm/msm/msm_fbdev.c:144:6: error: variable 'helper' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
if (!fbdev)
^~~~~~
Fixes: 3fb1f62f80a1 ("drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()")
Signed-off-by: Dave Airlie <airlied@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/msm/msm_fbdev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index c804e5ba682a..c1356aff87da 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm/msm_fbdev.c @@ -142,7 +142,7 @@ struct drm_fb_helper *msm_fbdev_init(struct drm_device *dev) fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL); if (!fbdev) - goto fail; + return NULL; helper = &fbdev->base; |