path: root/include/uapi/drm/i915_drm.h
diff options
authorDave Gordon <>2016-07-14 14:52:03 +0100
committerDaniel Vetter <>2016-07-19 09:06:16 +0200
commit9e2793f6e4e2ca452457e459f013cc8e6b08a789 (patch)
tree527d508c6959e5b950bb4a5ed161b06ab946882b /include/uapi/drm/i915_drm.h
parenta87848750ebc2c174879f5acaa1183044287fd03 (diff)
drm/i915: compile-time consistency check on __EXEC_OBJECT flags
Two different sets of flag bits are stored in the 'flags' member of a 'struct drm_i915_gem_exec_object2', and they're defined in two different source files, increasing the risk of an accidental clash. Some flags in this field are supplied by the user; these are defined in i915_drm.h, and they start from the LSB and work up. Other flags are defined in i915_gem_execbuffer, for internal use within that file only; they start from the MSB and work down. So here we add a compile-time check that the two sets of flags do not overlap, which would cause all sorts of confusion. Signed-off-by: Dave Gordon <> Reviewed-by: Daniel Vetter <> Signed-off-by: Daniel Vetter <> Link:
Diffstat (limited to 'include/uapi/drm/i915_drm.h')
1 files changed, 6 insertions, 5 deletions
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index d7e81a3886fd..51b9360bb376 100644
--- a/include/uapi/drm/i915_drm.h
+++ b/include/uapi/drm/i915_drm.h
@@ -698,12 +698,13 @@ struct drm_i915_gem_exec_object2 {
__u64 offset;
-#define EXEC_OBJECT_NEEDS_GTT (1<<1)
-#define EXEC_OBJECT_WRITE (1<<2)
+#define EXEC_OBJECT_NEEDS_GTT (1<<1)
+#define EXEC_OBJECT_WRITE (1<<2)
-#define EXEC_OBJECT_PINNED (1<<4)
+#define EXEC_OBJECT_PINNED (1<<4)
+/* All remaining bits are MBZ and RESERVED FOR FUTURE USE */
__u64 flags;
__u64 rsvd1;