path: root/include/uapi/drm/i915_drm.h
diff options
authorVille Syrjälä <>2018-02-02 22:42:31 +0200
committerVille Syrjälä <>2018-02-05 20:54:01 +0200
commit6ec5bd348934887494541bcc9b53d621b1f2962c (patch)
treeb95b8ce404dcb6e931617f36cb7000c9c639e488 /include/uapi/drm/i915_drm.h
parent01b8fdc5222007bdfc905941173f82576898a7f7 (diff)
drm/i915: Deprecate I915_SET_COLORKEY_NONE
Deprecate the silly I915_SET_COLORKEY_NONE flag. The obvious way to disable colorkey is to just set flags to 0, which is exactly what the intel ddx has been doing all along. Currently when userspace sets the flags to 0, we end up in a funny state where colorkey is disabled, but various colorkey vs. scaling checks still consider colorkey to be enabled, and thus we don't allow plane scaling to kick in. In case there is some other userspace out there that actually uses this flag (unlikely as this is an i915 specific uapi) we'll keep on accepting it. Signed-off-by: Ville Syrjälä <> Link: Reviewed-by: Chris Wilson <>
Diffstat (limited to 'include/uapi/drm/i915_drm.h')
1 files changed, 3 insertions, 1 deletions
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index 536ee4febd74..29fa48e4755d 100644
--- a/include/uapi/drm/i915_drm.h
+++ b/include/uapi/drm/i915_drm.h
@@ -1358,7 +1358,9 @@ struct drm_intel_overlay_attrs {
* active on a given plane.
-#define I915_SET_COLORKEY_NONE (1<<0) /* disable color key matching */
+#define I915_SET_COLORKEY_NONE (1<<0) /* Deprecated. Instead set
+ * flags==0 to disable colorkeying.
+ */
#define I915_SET_COLORKEY_SOURCE (1<<2)
struct drm_intel_sprite_colorkey {