path: root/drivers/gpu/drm
diff options
authorGustavo A. R. Silva <>2018-03-13 09:31:51 -0500
committerEric Anholt <>2018-03-16 15:51:52 -0700
commit0126b23c552c2bf9aa62a6cabce8c10e983ef436 (patch)
tree00c1ccf452341ceb3c40a35b5490c8cd1acc84a4 /drivers/gpu/drm
parent2f0e9d804935970a4ce0f58dd046b41881bfd8f3 (diff)
drm/vc4_validate: Remove VLA usage
In preparation to enabling -Wvla, remove VLA. In this particular case use macro ARRAY_SIZE so the length of array _bo_ can be computed at preprocessing time. The use of stack Variable Length Arrays needs to be avoided, as they can be a vector for stack exhaustion, which can be both a runtime bug or a security flaw. Also, in general, as code evolves it is easy to lose track of how big a VLA can get. Thus, we can end up having runtime failures that are hard to debug. Also, fixed as part of the directive to remove all VLAs from the kernel: Signed-off-by: Gustavo A. R. Silva <> Signed-off-by: Eric Anholt <> Reviewed-by: Eric Anholt <> Link:
Diffstat (limited to 'drivers/gpu/drm')
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/vc4/vc4_validate.c b/drivers/gpu/drm/vc4/vc4_validate.c
index 2db485abb186..eec76af49f04 100644
--- a/drivers/gpu/drm/vc4/vc4_validate.c
+++ b/drivers/gpu/drm/vc4/vc4_validate.c
@@ -753,7 +753,7 @@ validate_gl_shader_rec(struct drm_device *dev,
28, /* cs */
uint32_t shader_reloc_count = ARRAY_SIZE(shader_reloc_offsets);
- struct drm_gem_cma_object *bo[shader_reloc_count + 8];
+ struct drm_gem_cma_object *bo[ARRAY_SIZE(shader_reloc_offsets) + 8];
uint32_t nr_attributes, nr_relocs, packet_size;
int i;