path: root/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
diff options
authorDaniel Vetter <>2011-12-06 12:12:33 +0100
committerDave Airlie <>2011-12-07 10:44:40 +0000
commiteb1711bb94991e93669c5a1b5f84f11be2d51ea1 (patch)
treebd81e6b8f8c2547267e909ea2ac27bf472c15e8e /drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
parentdc87cd5c264cb587f16459285565830689ecf7a7 (diff)
drm/i915: fix infinite recursion on unbind due to ilk vt-d w/a
The recursion loop goes retire_requests->unbind->gpu_idle->retire_reqeusts. Every time we go through this we need a - active object that can be retired - and there are no other references to that object than the one from the active list, so that it gets unbound and freed immediately. Otherwise the recursion stops. So the recursion is only limited by the number of objects that fit these requirements sitting in the active list any time retire_request is called. Issue exercised by tests/gem_unref_active_buffers from i-g-t. There's been a decent bikeshed discussion whether it wouldn't be better to pass around a flag, but imo this is o.k. for such a limited case that only supports a w/a. Bugzilla: Signed-Off-by: Daniel Vetter <> Reviewed-by: Chris Wilson <chris@chris-wilson> [ickle- we built better bikesheds, but this keeps the rain off for now] Tested-by: Dave Airlie <> Signed-off-by: Dave Airlie <>
Diffstat (limited to 'drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c')
0 files changed, 0 insertions, 0 deletions