path: root/drivers/gpu/drm/arm/malidp_drv.c
diff options
authorLaurent Pinchart <>2018-01-17 23:55:29 +0200
committerLiviu Dudau <>2018-03-14 11:38:02 +0000
commit084ffbd7fd147ce6e114d82298c84f143d4fff7f (patch)
tree30c85a60e3348424083ad8b4f41108cc1d863a1d /drivers/gpu/drm/arm/malidp_drv.c
parentd862b2d622530d14072f3ae417a0525fb7361410 (diff)
drm: arm: malidp: Don't destroy planes manually in error handlers
The top-level error handler calls drm_mode_config_cleanup() which will destroy all planes. There's no need to destroy them manually in lower error handlers. As plane cleanup is now handled entirely by drm_mode_config_cleanup(), we must ensure that the plane .destroy() handler frees allocated memory for the plane object that was freed by malidp_de_planes_destroy(). Do so by replacing the call to devm_kfree() in the .destroy() handler by kfree(). devm_kfree() is currently a no-op as the plane memory is allocated with kzalloc(), not devm_kzalloc(). Signed-off-by: Laurent Pinchart <> Signed-off-by: Liviu Dudau <>
Diffstat (limited to 'drivers/gpu/drm/arm/malidp_drv.c')
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 3c628e43bf25..2b26f40a9786 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -278,7 +278,6 @@ static int malidp_init(struct drm_device *drm)
static void malidp_fini(struct drm_device *drm)
- malidp_de_planes_destroy(drm);