path: root/drivers/gpu/drm/arm/hdlcd_drv.c
diff options
authorDaniel Vetter <>2016-05-18 21:47:38 +0200
committerDave Airlie <>2016-05-21 07:03:31 +1000
commitfcee59065e58498682c60069cc6fb90694bab27e (patch)
treebea115621d1291a80d6bb57c2af3a36e366b84f5 /drivers/gpu/drm/arm/hdlcd_drv.c
parentfc7fedc20b7c819b9ef003afa16a64dc9e5ac30e (diff)
drm: Nuke ->vblank_disable_allowed
This was added in commit 0a3e67a4caac273a3bfc4ced3da364830b1ab241 Author: Jesse Barnes <> Date: Tue Sep 30 12:14:26 2008 -0700 drm: Rework vblank-wait handling to allow interrupt reduction. to stay backwards-compatible with old UMS code that didn't even tell the kernel when it did a modeset, so that the kernel could save/restore vblank counters. At worst this means vblanks will be somewhat funky on a setup that very likely no one still runs. So let's just nuke it. Plan B would be to set it unconditionally in drm_vblank_init for kms drivers, instead of in each driver separately. So if this patch breaks anything please only restore the hunks in drmP.h and drm_irq.c, plus add a check for DRIVER_MODESET in drm_vblank_init. Stumbled over this in a discussion on irc with Chris. Cc: Chris Wilson <> Cc: Alex Deucher <> Cc: Liviu Dudau <> Cc: Russell King <> Cc: Thierry Reding <> Cc: Eric Anholt <> Cc: Laurent Pinchart <> Cc: Inki Dae <> Cc: Tomi Valkeinen <> Cc: Mark Yao <> Cc: Sascha Hauer <> Cc: Philipp Zabel <> Signed-off-by: Daniel Vetter <> Reviewed-by: Alex Deucher <> Acked-by: Liviu Dudau <> Acked-by: Laurent Pinchart <> Tested-by: Laurent Pinchart <> Signed-off-by: Dave Airlie <>
Diffstat (limited to 'drivers/gpu/drm/arm/hdlcd_drv.c')
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
index 734899c4e4bb..b987c63ba8d6 100644
--- a/drivers/gpu/drm/arm/hdlcd_drv.c
+++ b/drivers/gpu/drm/arm/hdlcd_drv.c
@@ -379,7 +379,6 @@ static int hdlcd_drm_bind(struct device *dev)
DRM_ERROR("failed to initialise vblank\n");
goto err_vblank;
- drm->vblank_disable_allowed = true;