summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/amd
diff options
context:
space:
mode:
authorDave Airlie <airlied@redhat.com>2017-09-28 12:42:01 +1000
committerAlex Deucher <alexander.deucher@amd.com>2017-09-28 16:52:39 -0400
commite9d7dc62bc09bd95461d5444b54d59195b207fd6 (patch)
treee830b8ebab0cdc810d7363338bb5f39b21ddfe35 /drivers/gpu/drm/amd
parent5e0adbff084f33202db36be798c583a115990392 (diff)
amdgpu/dc: don't check for 0 on register read/writes always.
This adds ~50k to the driver text segment, and 10k to data segment. text data bss dec hex filename 2385556 39681 1045 2426282 2505aa drivers/gpu/drm/amd/amdgpu/amdgpu.o text data bss dec hex filename 2336593 28857 1045 2366495 241c1f drivers/gpu/drm/amd/amdgpu/amdgpu.o Signed-off-by: Dave Airlie <airlied@redhat.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd')
-rw-r--r--drivers/gpu/drm/amd/display/dc/dm_services.h9
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/dm_services.h b/drivers/gpu/drm/amd/display/dc/dm_services.h
index 8ab0af6f4c6b..c976e2aa10e0 100644
--- a/drivers/gpu/drm/amd/display/dc/dm_services.h
+++ b/drivers/gpu/drm/amd/display/dc/dm_services.h
@@ -96,6 +96,9 @@ irq_handler_idx dm_register_interrupt(
*
*/
+/* enable for debugging new code, this adds 50k to the driver size. */
+/* #define DM_CHECK_ADDR_0 */
+
#define dm_read_reg(ctx, address) \
dm_read_reg_func(ctx, address, __func__)
@@ -105,12 +108,12 @@ static inline uint32_t dm_read_reg_func(
const char *func_name)
{
uint32_t value;
-
+#ifdef DM_CHECK_ADDR_0
if (address == 0) {
DC_ERR("invalid register read; address = 0\n");
return 0;
}
-
+#endif
value = cgs_read_register(ctx->cgs_device, address);
return value;
@@ -125,10 +128,12 @@ static inline void dm_write_reg_func(
uint32_t value,
const char *func_name)
{
+#ifdef DM_CHECK_ADDR_0
if (address == 0) {
DC_ERR("invalid register write. address = 0");
return;
}
+#endif
cgs_write_register(ctx->cgs_device, address, value);
}