summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/amd/display/dc/dce120
diff options
context:
space:
mode:
authorZeyu Fan <Zeyu.Fan@amd.com>2017-04-03 11:54:11 -0400
committerAlex Deucher <alexander.deucher@amd.com>2017-09-26 17:23:15 -0400
commit632550d71fcf78d495cfd1d321427e634b662f23 (patch)
tree50c428b961b2d02e3a81ec76883738c912562756 /drivers/gpu/drm/amd/display/dc/dce120
parent035e0fe5485fc1881a3c24eaac86832d804242e9 (diff)
drm/amd/display: Fix hotspot programming during set cursor position.
- Remove x,y hotspot from dc_cursor_attributes. Only program it through setPosition. Signed-off-by: Zeyu Fan <Zeyu.Fan@amd.com> Acked-by: Harry Wentland <Harry.Wentland@amd.com> Reviewed-by: Zeyu Fan <Zeyu.Fan@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/display/dc/dce120')
-rw-r--r--drivers/gpu/drm/amd/display/dc/dce120/dce120_ipp_cursor.c15
1 files changed, 4 insertions, 11 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_ipp_cursor.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_ipp_cursor.c
index d520b5d7aa81..15671fd2cb9c 100644
--- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_ipp_cursor.c
+++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_ipp_cursor.c
@@ -151,11 +151,10 @@ void dce120_ipp_cursor_set_position(
CURSOR_X_POSITION, position->x,
CURSOR_Y_POSITION, position->y);
- if (position->hot_spot_enable)
- DCP_REG_SET_2(
- DCP0_CUR_HOT_SPOT,
- CURSOR_HOT_SPOT_X, position->x_hotspot,
- CURSOR_HOT_SPOT_Y, position->y_hotspot);
+ DCP_REG_SET_2(
+ DCP0_CUR_HOT_SPOT,
+ CURSOR_HOT_SPOT_X, position->x_hotspot,
+ CURSOR_HOT_SPOT_Y, position->y_hotspot);
/* unlock cursor registers */
lock(ipp110, false);
@@ -176,12 +175,6 @@ bool dce120_ipp_cursor_set_attributes(
attributes->attribute_flags.bits.ENABLE_MAGNIFICATION,
attributes->attribute_flags.bits.INVERSE_TRANSPARENT_CLAMPING);
- /* Program hot spot coordinates */
- DCP_REG_SET_2(
- DCP0_CUR_HOT_SPOT,
- CURSOR_HOT_SPOT_X, attributes->x_hot,
- CURSOR_HOT_SPOT_Y, attributes->y_hot);
-
/*
* Program cursor size -- NOTE: HW spec specifies that HW register
* stores size as (height - 1, width - 1)