diff options
authorVille Syrjälä <>2017-11-23 21:04:50 +0200
committerVille Syrjälä <>2018-01-23 17:41:32 +0200
commit872d20dfbd91b296ebcd0b222f5fa3da89e0d1cf (patch)
parenta2936e3d9a9cb2ce192455cdec3a8cfccc26b486 (diff)
drm/arm/hdlcd: Use drm_mode_get_hv_timing() to populate plane clip rectangle
Use drm_mode_get_hv_timing() to fill out the plane clip rectangle. Note that this replaces crtc_state->adjusted_mode usage with crtc_state->mode. The latter is the correct choice since that's the mode the user provided and it matches the plane crtc coordinates the user also provided. Once everyone agrees on this we can move the clip handling into drm_atomic_helper_check_plane_state(). Cc: Laurent Pinchart <> Cc: Liviu Dudau <> Cc: Brian Starkey <> Cc: Mali DP Maintainers <> Signed-off-by: Ville Syrjälä <> Link: Acked-by: Liviu Dudau <> Reviewed-by: Thierry Reding <>
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c
index 630721f429f7..877647ef35a9 100644
--- a/drivers/gpu/drm/arm/hdlcd_crtc.c
+++ b/drivers/gpu/drm/arm/hdlcd_crtc.c
@@ -249,8 +249,9 @@ static int hdlcd_plane_atomic_check(struct drm_plane *plane,
return -EINVAL;
- clip.x2 = crtc_state->adjusted_mode.hdisplay;
- clip.y2 = crtc_state->adjusted_mode.vdisplay;
+ if (crtc_state->enable)
+ drm_mode_get_hv_timing(&crtc_state->mode,
+ &clip.x2, &clip.y2);
return drm_atomic_helper_check_plane_state(state, crtc_state, &clip,