diff options
| author | Zongmin Zhou <zhouzongmin@kylinos.cn> | 2023-08-01 10:53:09 +0800 |
|---|---|---|
| committer | Maxime Ripard <mripard@kernel.org> | 2023-11-06 09:37:03 +0100 |
| commit | 0e8b9f258baed25f1c5672613699247c76b007b5 (patch) | |
| tree | 11228e4f3631d25b9e5277eb26fbf05df2a4f842 | |
| parent | 101c9f637efa1655f55876644d4439e552267527 (diff) | |
drm/qxl: prevent memory leakdrm-misc-fixes-2023-11-08
The allocated memory for qdev->dumb_heads should be released
in qxl_destroy_monitors_object before qxl suspend.
otherwise,qxl_create_monitors_object will be called to
reallocate memory for qdev->dumb_heads after qxl resume,
it will cause memory leak.
Signed-off-by: Zongmin Zhou <zhouzongmin@kylinos.cn>
Link: https://lore.kernel.org/r/20230801025309.4049813-1-zhouzongmin@kylinos.cn
Reviewed-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
| -rw-r--r-- | drivers/gpu/drm/qxl/qxl_display.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 6492a70e3c39..404b0483bb7c 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -1229,6 +1229,9 @@ int qxl_destroy_monitors_object(struct qxl_device *qdev) if (!qdev->monitors_config_bo) return 0; + kfree(qdev->dumb_heads); + qdev->dumb_heads = NULL; + qdev->monitors_config = NULL; qdev->ram_header->monitors_config = 0; |