summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNatalia Petrova <n.petrova@fintech.ru>2023-05-12 13:33:20 +0300
committerLyude Paul <lyude@redhat.com>2023-06-13 16:53:00 -0400
commit55b94bb8c42464bad3d2217f6874aa1a85664eac (patch)
tree8c2d1fc76afea503890ff2bf9a694cb888ae7605
parent20a2ce87fbaf81e4c3dcb631d738e423959eb320 (diff)
drm/nouveau: add nv_encoder pointer check for NULLdrm-misc-fixes-2023-06-16
Pointer nv_encoder could be dereferenced at nouveau_connector.c in case it's equal to NULL by jumping to goto label. This patch adds a NULL-check to avoid it. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 3195c5f9784a ("drm/nouveau: set encoder for lvds") Signed-off-by: Natalia Petrova <n.petrova@fintech.ru> Reviewed-by: Lyude Paul <lyude@redhat.com> [Fixed patch title] Signed-off-by: Lyude Paul <lyude@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230512103320.82234-1-n.petrova@fintech.ru
-rw-r--r--drivers/gpu/drm/nouveau/nouveau_connector.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 5dbf025e6873..f75c6f09dd2a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -730,7 +730,8 @@ out:
#endif
nouveau_connector_set_edid(nv_connector, edid);
- nouveau_connector_set_encoder(connector, nv_encoder);
+ if (nv_encoder)
+ nouveau_connector_set_encoder(connector, nv_encoder);
return status;
}