diff options
| author | Jonathan Cavitt <jonathan.cavitt@intel.com> | 2024-07-12 14:41:56 -0700 | 
|---|---|---|
| committer | Tvrtko Ursulin <tursulin@ursulin.net> | 2024-07-23 09:34:13 +0000 | 
| commit | 26720dd2b5a1d088bff8f7e6355fca021c83718f (patch) | |
| tree | 60359b2c47a927d029cb600be3ce167924a22a0c | |
| parent | 65564157ae64cec0f527583f96e32f484f730f92 (diff) | |
drm/i915: Allow NULL memory regiondrm-intel-next-fixes-2024-07-25
Prevent a NULL pointer access in intel_memory_regions_hw_probe.
Fixes: 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup warning")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11704
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240712214156.3969584-1-jonathan.cavitt@intel.com
(cherry picked from commit d75dec1fcbcb05b021c08b62551649567ab8955c)
Signed-off-by: Tvrtko Ursulin <tursulin@ursulin.net>
| -rw-r--r-- | drivers/gpu/drm/i915/intel_memory_region.c | 6 | 
1 files changed, 4 insertions, 2 deletions
| diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c index 172dfa7c3588..d40ee1b42110 100644 --- a/drivers/gpu/drm/i915/intel_memory_region.c +++ b/drivers/gpu/drm/i915/intel_memory_region.c @@ -368,8 +368,10 @@ int intel_memory_regions_hw_probe(struct drm_i915_private *i915)  			goto out_cleanup;  		} -		mem->id = i; -		i915->mm.regions[i] = mem; +		if (mem) { /* Skip on non-fatal errors */ +			mem->id = i; +			i915->mm.regions[i] = mem; +		}  	}  	for (i = 0; i < ARRAY_SIZE(i915->mm.regions); i++) { | 
