summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-06-10_dbus_header_byteswap: change the first byte of the message, not just the ↵Simon McVittie1-0/+6
struct member This has been wrong approximately forever, for instance see: http://lists.freedesktop.org/archives/dbus/2007-March/007357.html Bug: https://bugs.freedesktop.org/show_bug.cgi?id=38120 Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=629938 Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
2011-06-10Consistently use atomic operations for all access to DBusConnection refcountSimon McVittie1-66/+18
Trying to mix atomic operations with locked non-atomic operations is broken: the atomic ops aren't necessarily atomic with respect to the locked non-atomic ops, and the non-atomic ops aren't protected by the lock because the atomic ops can change the refcount behind their back. In theory we could use the connection lock if atomic ops aren't supported (making a per-connection lock cheaper than the global lock used to implement atomic ops) *and* our mutexes are recursive (making it safe against deadlocks)... but life's too short. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=38005 Tested-by: Will Manley <freedesktop williammanley net> Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
2011-06-08NEWSSimon McVittie1-0/+3
2011-06-08bus: use ln -fs to enable dbus in systemd, not $(LN_S)Simon McVittie1-4/+6
Using $(LN_S) is inappropriate because it could in theory mean either ln -s, ln or cp -p depending on autoconf checks. Not using -f breaks reinstallation directly from source (DESTDIR unset), because the symlinks will already exist. Because systemd isn't currently portable to non-Linux, let alone non-SUS-compliant systems, it seems safe to assume that ln -fs behaves as specified by SUS if systemd was found. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37870 Reviewed-by: Colin Walters <walters@verbum.org>
2011-06-07NEWSSimon McVittie1-0/+17
2011-06-07Remove support for -Wl,--gc-sections altogetherSimon McVittie2-32/+4
Packagers should only enable this flag if they have confirmed that it actually works on their toolchain (it's the sort of rarely used feature that frequently regresses on obscure architectures/OSs without anyone noticing), and also confirmed that it is actually a significant size win for their configuration. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33466 Reviewed-by: Colin Walters <walters@verbum.org>
2011-06-07don't try to build dbus-daemon-launch-helper for WindowsMark Brand1-0/+2
Fixed regression in b0acded which breaks build for Windows. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37838 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
2011-06-01Use #!/bin/sh for run-with-tmp-session-bus.shSimon McVittie1-1/+1
It doesn't seem to have any bashisms, and bash isn't in /bin on *BSD. Suggested by Timothy Redaelli. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35880
2011-06-01add a release name here tooSimon McVittie1-0/+2
2011-06-01Development versionSimon McVittie1-1/+1
2011-06-01Prepare version 1.4.10dbus-1.4.10Simon McVittie2-3/+3
2011-05-25NEWSSimon McVittie1-0/+2
2011-05-25bus_context_log: divert messages to stderr if we're not using syslogSimon McVittie1-2/+13
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25process_config_first_time_only: initialize syslog as intended.Simon McVittie3-3/+4
On Linux, we previously called openlog() (with different options!) while initializing SELinux; leave SELinux messages as LOG_USER|LOG_INFO in case anyone was relying on that, but let the rest of our log messages come out as LOG_DAEMON. Also enable LOG_PERROR (copy syslog messages to stderr) unconditionally; we can make this an autoconf check if anyone's pet Unix doesn't have LOG_PERROR. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25_dbus_init_system_log: remove FIXME on WindowsSimon McVittie1-1/+1
We don't need any initialization here, so there's nothing to fix. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25bus_context_check_security_policy: syslog if we hit the outgoing quotaSimon McVittie1-10/+13
In practice, nothing copes with missing broadcast signals, so the least we can do is make the failure mode visible. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25bus_context_check_security_policy: for SELinux denials, share code to set errorsSimon McVittie1-15/+6
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25bus_context_check_security_policy: factor out complain_about_messageSimon McVittie1-98/+85
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25Check for X even if X11 autolaunching is disabledSimon McVittie5-11/+24
DBUS_ENABLE_X11_AUTOLAUNCH obviously requires DBUS_BUILD_X11. However, the converse is not true. If DBUS_BUILD_X11 is defined, dbus-launch will be able to connect to the X server to determine when the session ends; most distributors will want this, but it can be disabled with the standard Autoconf option --without-x. If DBUS_ENABLE_X11_AUTOLAUNCH is *also* defined, dbus-launch and libdbus will be willing to perform autolaunch. Again, most distributors will want this, but it can be disabled with --disable-x11-autolaunch. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19997 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25test-autolaunch: don't expect autolaunching to work if X11 is disabledSimon McVittie1-0/+19
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19997 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25NEWSSimon McVittie1-0/+2
2011-05-25When checking for __sync_sub_and_fetch, don't underquote, to shut up recent ↵Simon McVittie1-2/+2
autoconf Without the correct number of levels of quoting, autoconf mistakenly believes we didn't use AC_LANG_SOURCE where required. (In fact, AC_LANG_PROGRAM calls AC_LANG_SOURCE.) Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19681 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25When checking for va_copy, use AC_LANG_SOURCE to shut up recent autoconfSimon McVittie1-4/+4
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19681 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25Use TP_ADD_COMPILER_FLAG to simplify application of warning-like CFLAGSSimon McVittie1-46/+14
This also means we check for support for them. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19681 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25Use TP_COMPILER_WARNINGS for all -Wfoo optionsSimon McVittie1-84/+34
This consistently checks whether all these options actually work in the current version of gcc. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19681 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25Import tp-compiler-flag.m4 and tp-compiler-warnings.m4 from telepathy-glibSimon McVittie2-0/+92
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19681 Reviewed-by: Colin Walters <walters@verbum.org>
2011-05-25NEWSSimon McVittie1-0/+6
2011-05-25handle_server_data_anonymous_mech: remove unnecessary debug outputSimon McVittie1-12/+0
Doing a malloc and a hex-encoding pass just to produce a _dbus_verbose message (i.e. a message that, in practice, nobody will see) seems like overkill, and this block had incorrect error handling (not checking the result of _dbus_string_init) which upsets static analysis tools. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=29881 Bug-NB: NB#180486 Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
2011-05-25dbus-launch: pass_info: always free strings on OOMSimon McVittie1-7/+10
This doesn't really do anything, because we're about to exit anyway, but it placates static analysis tools. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=29881 Bug-NB: NB#180486 Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
2011-05-25dbus-send: remove minor dead codeSimon McVittie1-3/+1
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33128 Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
2011-05-25dbus_connection_dispatch: remove dead codeSimon McVittie1-3/+0
There's no way pending can be non-NULL here; if it was, we'd have jumped straight past this block (getting filters from the connection), because replies to pending calls don't go through filters. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33128 Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
2011-05-25Spelling fix.Ralf Habacker1-2/+2
2011-05-25Definition is obsolate with commit e0fc90bdf2c60a4c77fffaf490d6f06b2bd6999dRalf Habacker1-5/+0
2011-05-25To avoid double dbus version definitions take values from configure.ac.Ralf Habacker1-3/+7
2011-05-25DBusNonceFile: don't always fail when use_subdir=TRUE, i.e. on UnixSimon McVittie1-1/+1
In shell-like pseudocode, the desired result is: if $use_subdir dir = $tmpdir/dbus_nonce-$random path = $dir/nonce mkdir $dir write file at $path else dir = $user_owned_place path = $dir/dbus_nonce-$random write file at $path However, /nonce was accidentally appended to $dir instead of $path, resulting in an attempt to mkdir /tmp/dbus_nonce-XXXX/nonce when dbus_nonce-XXXX hadn't been created yet. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34569 Tested-by: David Zeuthen <davidz@redhat.com> Reviewed-by: David Zeuthen <davidz@redhat.com>
2011-05-25Relax review criteria for the review cabal themselves, as discussed on-listSimon McVittie1-0/+14
Colin agreed in principle and nobody actually objected, so here we go...
2011-05-25Add davidz to the review cabalSimon McVittie1-2/+1
Acked-by: Will Thompson <will.thompson@collabora.co.uk> Acked-by: Colin Walters <walters@verbum.org>
2011-05-03dbus_connection_can_send_type: clarify that invalid codes are allowed hereSimon McVittie1-1/+1
This is sufficiently unusual that it seems worth saying explicitly Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35182 Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
2011-04-29NEWSSimon McVittie1-0/+2
2011-04-29minotaur: bail if asked to monitor >1 busWill Thompson1-11/+35
A coworker was just tripped up by `dbus-monitor --session --system` only monitoring the system bus. This patch would have saved him reproducing a tricky bug several times! Bug: https://bugs.freedesktop.org/show_bug.cgi?id=26548 Reviewed-by: Colin Walters <walters@verbum.org> Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
2011-04-27NEWS for 1.4Simon McVittie1-0/+4
2011-04-27machine-id: fall back to reading /etc/machine-id if D-Bus machine ID is not ↵Lennart Poettering1-1/+12
available Newer systemd-based systems support a global machine ID with the same metrics as the D-Bus machine ID, but more powerful semantics (for example on ro media) in /etc/machine-id. If the D-Bus machine ID cannot be read, fall back to the systemd machine ID. This is a first step towards allowing D-Bus to be started up during early boot where /var is not available. [plus a whitespace fix -smcv] Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Colin Walters <walters@verbum.org> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35228
2011-04-27_dbus_check_fdleaks_enter, _dbus_check_fdleaks_leave: whitespaceSimon McVittie1-12/+12
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35173 Reviewed-by: Colin Walters <walters@verbum.org>
2011-04-27Don't report file descriptors as "leaked" if they were already openSimon McVittie3-10/+90
This is necessary to run the regression tests under valgrind (if telling it to output to a dedicated fd), gdb, fakeroot etc. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35173 Reviewed-by: Colin Walters <walters@verbum.org>
2011-04-26NEWSSimon McVittie1-0/+2
2011-04-26Merge remote-tracking branch 'origin/dbus-1.4' into dbus-1.4Simon McVittie1-8/+60
2011-04-26NEWSSimon McVittie1-0/+7
2011-04-26activation: Use _dbus_system_log for activation informationColin Walters1-8/+60
Log when we are activating something (and whether it's via systemd) as well as when we fail to activate, and when one succeeds. https://bugs.freedesktop.org/show_bug.cgi?id=35705
2011-04-26Add dbus-1-uninstalled.pc.inSimon McVittie2-0/+18
See: http://smcv.pseudorandom.co.uk/2008/09/pc-uninstalled/ Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32827 Reviewed-by: Colin Walters <walters@verbum.org>
2011-04-26Add support for --disable-gc-sections for broken toolchainsSimon McVittie1-38/+26
Also use AC_LINK_IFELSE rather than reinventing it as a shell function. This was the last user of ld_supports_flag, so, delete it. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33466 Reviewed-by: Colin Walters <walters@verbum.org>