diff options
author | Simon McVittie <smcv@collabora.com> | 2018-08-17 15:42:17 +0100 |
---|---|---|
committer | Simon McVittie <smcv@collabora.com> | 2018-12-03 16:32:31 +0000 |
commit | aa427663405284853f42923fb272e195b7b4c3ac (patch) | |
tree | a38a47b0ba86e6661f1efc042a12c13ca9238fb2 | |
parent | a6bae612ad5fde1e310aadd357ef34bdde50ed1e (diff) |
activation: Don't leak if delivering activation message is forbidden
This is technically a denial of service because the dbus-daemon will
run out of memory eventually, but it's a very slow and noisy one,
because all the rejected messages are also very likely to have
been logged to the system log.
Detected by AddressSanitizer.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Resolves: https://gitlab.freedesktop.org/dbus/dbus/issues/234
Reviewed-by: pwithnall
-rw-r--r-- | bus/activation.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/bus/activation.c b/bus/activation.c index 6f009f5c..99404b92 100644 --- a/bus/activation.c +++ b/bus/activation.c @@ -1267,6 +1267,7 @@ bus_activation_send_pending_auto_activation_messages (BusActivation *activation entry->activation_message); } + dbus_error_free (&error); link = next; continue; } |