diff options
author | Simon McVittie <smcv@collabora.com> | 2018-08-17 15:42:17 +0100 |
---|---|---|
committer | Simon McVittie <smcv@collabora.com> | 2018-12-03 16:33:27 +0000 |
commit | 1c0123cabeec8cba869cd7f8f36ed653178750e8 (patch) | |
tree | 25e10c4f322ca6b9cc2baa6e6584a3d9b58ff79d | |
parent | a051b95f6bc83c9e95dee82b237703f35ba7fd47 (diff) |
activation: Don't leak if delivering activation message is forbidden
This is technically a denial of service because the dbus-daemon will
run out of memory eventually, but it's a very slow and noisy one,
because all the rejected messages are also very likely to have
been logged to the system log.
Detected by AddressSanitizer.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Resolves: https://gitlab.freedesktop.org/dbus/dbus/issues/234
Reviewed-by: pwithnall
-rw-r--r-- | bus/activation.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/bus/activation.c b/bus/activation.c index a8c0e015..6752acc9 100644 --- a/bus/activation.c +++ b/bus/activation.c @@ -1206,6 +1206,7 @@ bus_activation_send_pending_auto_activation_messages (BusActivation *activation entry->activation_message); } + dbus_error_free (&error); link = next; continue; } |