AgeCommit message (Collapse)AuthorFilesLines
2015-03-05xlib: Remove queued event from _XReadEventsHenry (Yu) Song1-0/+5
Following patch fixes a memory leak in xlib surface. Reviewed-by: Bryce Harrington <>
2015-03-05headers: fix include order for AIX, bug#89354Michael Haubenwallner1-2/+2
also for cairo-xcb-private.h
2015-03-05headers: fix include order for AIX, bug#89354Michael Haubenwallner3-3/+3
2015-03-05perf: fix include order for AIX, bug#89354Michael Haubenwallner1-1/+1
2015-03-05perf/micro: fix include order for AIX, bug#89354Michael Haubenwallner4-4/+4
2015-03-05test: fix include order for AIX, bug#89354Michael Haubenwallner41-49/+52
2015-03-05define _GETDELIM for getline() on AIXMichael Haubenwallner1-0/+2
On AIX 6.1, getdelim() and getline() are not provided by default, causing a gcc compilation error. With _GETDELIM defined, AIX's stdio.h header provides definitions for these routines. Fixes: Reviewed-by: Bryce Harrington <>
2015-03-05skip MAP_NORESERVE when unsupportedMichael Haubenwallner2-0/+8
Fixes a compilation on AIX ('MAP_NORESERVE' undeclared) Fixes: Signed-off-by: Bryce Harrington <>
2015-03-05fix conflicting types for 'sync' on AIX, bug#89338Michael Haubenwallner2-8/+8
2015-02-05quartz: Remove call to obsolete CGFontGetGlyphPathAndrea Canciani1-6/+4
CGFontGetGlyphPath was not public and is not available anymore on modern OSX/iOS systems. The same functionality is available through the CoreText API since OSX 10.5. Based on a patch by Simon Cozens. Fixes
2015-02-02win32: Fix crash from win32 surface's image size too smallMassimo Valentini1-4/+4
Beginning in 1.12, a crash can occur when the win32 surface's image size does not cover the entire surface (e.g. due to clipping regions). This patch enlarges the fallback surface created of the amount necessary not to write past the end of the DIB. It assumes that Clip applied to an HDC are clamped to (0,0,width,height) of the HDC. Fixes: Reviewed-by: Bryce Harrington <>
2015-01-20cairo-trace: Fix duplicated surface push on similar-imageEmanuele Aina1-2/+1
The current code results in trace lines with the source surface being pushed on the stack two times instead of one: s1 s1 //ARGB32 48 48 similar-image % s2 Instead of: s1 //ARGB32 48 48 similar-image % s2 This greatly confuses later commands when the script was replayed, causing traces for trivial GTK3 programs to be unplayable, usually yielding the following error: "invalid value (typically too big) for the size of the input (surface, pattern, etc.)" Drop the duplicated entry from the trace line printed by the cairo_surface_create_similar_image() override. Fixes: Signed-off-by: Emanuele Aina <>
2015-01-17xlib-xcb: Don't be lazy and use the real xcb_screen_tUli Schlachter1-15/+18
Signed-off-by: Uli Schlachter <>
2015-01-17xcb: Query the display's subpixel order via RENDERUli Schlachter4-29/+43
With commit e691d242, the xcb backend started parsing the resources, just like cairo-xlib does. One behavior from cairo-xlib was missing: If no Xft.rgba property was specified, cairo-xlib defaults to the screen's subpixel order. This commit brings that last bit of functionality to cairo-xcb (but currently disabled due to commit e0c0a673). This commits adds a new array to cairo_xcb_connection_t that contains the subpixel order for each screen. There is also a new member in cairo_xcb_screen_t which contains the subpixel order of that screen and which is initialized from the array when the screen is constructed. With this in place, the resource-parsing code can just pick the subpixel order from the screen if needed. Signed-off-by: Uli Schlachter <>
2015-01-03font: Actually perform destruction of fontsAndrea Canciani1-2/+3
Commit 337ab1f8d9e29086bfb4001508b28835b41c6390 introduced delayed font destruction to overcome a race, but prevented the correct cleanup of the font cache. This caused fonts to stay in the cache and caused a crash in the api-special-cases (when running the test suite with -f). Fixes api-special-cases,
2014-12-31xlib: Bump reference count for recording surface replaysChris Wilson1-4/+10
The snapshot takes a reference to the target recording surface in order to enable it for use by multiple treads. In order to balance this, the other two sources of recording surface must also take a reference and for us to release that reference after the replay. Otherwise, we end up with a memory leak: ==1== 1,392 bytes in 3 blocks are definitely lost in loss record 1 of 7 ==1== at 0x4A06BCF: malloc (in /usr/lib64/valgrind/ ==1== by 0x4C7042D: _cairo_recording_surface_snapshot (cairo/src/cairo-recording-surface.c:1427) ==1== by 0x4C842BE: _cairo_surface_snapshot_copy_on_write (cairo/src/cairo-surface-snapshot.c:189) ==1== by 0x4C7E7E0: _cairo_surface_detach_snapshot (cairo/src/cairo-surface.c:348) ==1== by 0x4C7E55B: _cairo_surface_detach_snapshots (cairo/src/cairo-surface.c:333) ==1== by 0x4C7E55B: _cairo_surface_flush (cairo/src/cairo-surface.c:1545) ==1== by 0x4C7E6CC: _cairo_surface_finish_snapshots (cairo/src/cairo-surface.c:1017) ==1== by 0x4C7E6CC: cairo_surface_destroy (cairo/src/cairo-surface.c:961) ==1== by 0x4C625A7: cairo_pattern_destroy (cairo/src/cairo-pattern.c:1131) ==1== by 0x4C3FAC6: _cairo_gstate_fini (cairo/src/cairo-gstate.c:225) ==1== by 0x4C3C68C: _cairo_default_context_fini (cairo/src/cairo-default-context.c:75) ==1== by 0x4C3C708: _cairo_default_context_destroy (cairo/src/cairo-default-context.c:93) ==1== by 0x43E576: record_get (cairo/test/record-extend.c:158) ==1== by 0x43E576: record_replay (cairo/test/record-extend.c:173) ==1== by 0x40E22D: cairo_test_for_target (cairo/test/cairo-test.c:929) ==1== by 0x40E22D: _cairo_test_context_run_for_target (cairo/test/cairo-test.c:1532) ==1== by 0x40B6C0: _cairo_test_runner_draw (cairo/test/cairo-test-runner.c:255) ==1== by 0x40B6C0: main (cairo/test/cairo-test-runner.c:937) Reported-by: Massimo Valentini <> Bugzilla: Signed-off-by: Chris Wilson <>
2014-12-06test: Free test listAndrea Canciani1-0/+1
When running the cairo-test-suite, valgrind reports each of the registered test as a leak, because they are _list_prepend()'ed, but the tests list is never _list_free()'d. Fixes the following valgrind error: malloc (in /usr/lib/valgrind/ cairo_boilerplate_xmalloc (cairo-boilerplate-system.c:47) cairo_test_register (cairo-test-runner.c:131) _cairo_test_runner_register_tests (cairo-test-constructors.c:1112) main (cairo-test-runner.c:714) Signed-off-by: Bryce Harrington <>
2014-12-06test: Release owned patternAndrea Canciani1-1/+3
The pattern created by cairo_pattern_create_rgb() is owned by the caller, hence it needs to be released. Fixes the following valgrind error: malloc (in /usr/lib/valgrind/ _cairo_pattern_create_solid (cairo-pattern.c:605) _cairo_pattern_create_in_error (cairo-pattern.c:628) cairo_pop_group (cairo.c:552) test_cairo_push_group (api-special-cases.c:157) preamble (api-special-cases.c:1766) main (cairo-test-runner.c:228) Signed-off-by: Bryce Harrington <>
2014-12-06tor-scan-converter: Correctly align 64bit typesUli Schlachter1-15/+23
On 32bit SPARC the scan converter was causing a SIGBUS due to an unaligned memory access while accessing an int64_t. This memory accessing was to struct quorem's rem member. This crash occurred because the tor-scan-converter contains its own implementation of a memory pool. This implementation only guarantees an alignment of sizeof(void *), which is less than what a 64 bit type requires on 32bit platforms. This 4 byte alignment is guaranteed, because struct _pool_chunk (which is the struct that is used for managing free space) contains elements of that size and so the size of that struct is a multiple of this size as well. This problem was introduced with commit 03c3d4b7c15. To fix this problem, this commit introduces a int64_t member to struct _pool_chunk that marks the beginning of the free data space. Thanks to this, the compiler ensures proper alignment and sizeof(struct _pool_chunk) becomes a multiple of 8. However, previously the end of the struct marked the beginning of the data and sizeof() was used for correctly calculating offsets to the data section. So, just adding such a member would work, but would also waste some memory. To avoid this, this commit also changes the rest of the pool implementation to accommodate. Reported-by: Nicolas Setton <> Signed-off-by: Uli Schlachter <> Reviewed-by: Bryce Harrington <>
2014-12-05image: Fix crash in _fill_xrgb32_lerp_opaque_spansBryce Harrington1-2/+2
If a span length is negative don't go out of bounds processing the fill data. Patch thanks to Ilya Sakhnenko <> on mailing list. Signed-off-by: Bryce Harrington <>
2014-11-20win32: Fix compilation of 'cairo-path-stroke-traps.c' with MSVC8Hans Breuer1-4/+6
"The issue here is that Visual Studio 2005+ is quite strict on type conversions (so it wants code to be clear enough on conversions)." Fixes:
2014-11-20Refactor ARRAY_LENGTH macro definitions in test codeBryce Harrington7-16/+6
2014-11-20test: Use ARRAY_LENGTH macroBryce Harrington3-4/+3
2014-11-20pdf-operators: fix bug with RTL textAdrian Johnson1-1/+5
bug 86461
2014-11-12Fix one more warning from check-doc-syntax.shRavi Nanjundappa1-2/+2
$ ./ Checking documentation for incorrect syntax ./cairo-pattern.c (3342): ERROR: Will invalid doc id (should be 'cairo_...:') The proposed changes fixes the warning about the documentation style used in cairo. Signed-off-by: Ravi Nanjundappa <>
2014-11-06xcb: Don't crash when swapping a 0-sized glyphAdam Jackson1-0/+6
malloc(0) needn't return NULL, and on glibc, doesn't. Then we encounter a loop of the form do { ... } while (--c), which doesn't do quite what you were hoping for when c is initially 0. Since there's nothing to swap in this case, just bomb out. Signed-off-by: Adam Jackson <>
2014-11-06xlib: Don't crash when swapping a 0-sized glyphAdam Jackson1-0/+6
malloc(0) needn't return NULL, and on glibc, doesn't. Then we encounter a loop of the form do { ... } while (--c), which doesn't do quite what you were hoping for when c is initially 0. Since there's nothing to swap in this case, just bomb out. Signed-off-by: Adam Jackson <>
2014-10-31Improve performance of cpu_to_be32 and be32_to_cpuAdrian Johnson1-1/+1
By switching to the more common form, gcc and clang emit a single bswap instruction and truetype subsetting of large fonts runs about 15% faster.
2014-10-31pdf-operators: only wrap text strings for PS outputAdrian Johnson6-16/+31
since the PS Document Structing Conventions impose a 255 character line limit. PDF does not require wrapping. pdf-operators is designed to emit the same output for PS and PDF. Unfortunately some PDF interpreters don't like strings split with '\\\n' and some PS interpreters don't like strings split with ')('. So we are forced to make pdf-operators handling string wrapping differently for PDF and PS. Bug 85662
2014-10-29Drop the target-specific huge-radial.pdf.*.ref.png imagesBryce Harrington2-0/+0
These two images are mis-rendered (clearly evident from visual inspection). By removing them, the test will fall back to the more general format-specific images, huge-radial.argb32.ref.png and huge-radial.rgb24.ref.png. Note that the huge-radial.pdf tests still fail to pass, but the pdiff looks more sensible. Bugzilla: Signed-off-by: Bryce Harrington <>
2014-10-29RELEASING: Be explicit as to which tag is pushedBryce Harrington1-1/+1
2014-10-28Fix warnings from check-doc-syntax.shRavi Nanjundappa1-2/+2
$ ./ Checking documentation for incorrect syntax ./cairo-pattern.c (3346): ERROR: Will bad line: ' */' ./cairo-pattern.c (3346): ERROR: Will documentation comment not closed with **/ ./cairo-pattern.c (3422): ERROR: _cairo_pattern_sampled_area invalid doc id (should be 'cairo_...:') The warnings are about the documentation style used in cairo Signed-off-by: Ravi Nanjundappa <>
2014-10-21build: fix regression on mingwAdrian Johnson1-2/+2
7cfebce1 removed the filename extension for executables. Patch from Bug 85120
2014-10-19tor-scan-converter: can't do_fullrow when intersection in row + 0.5subrowMassimo Valentini1-2/+2
the active edges list must be left sorted at the next possible use and since full_row does not deal with intersections it is not usable when there is an intersection in the top half of the next row first subrow Reported-and-tested-by: Matthew Leach Bugzilla: Reviewed-by: Chris Wilson <>
2014-10-18Revert "Add execution bit for"Bryce Harrington1-0/+0
This reverts commit 5c17bf1a33b8e76edeb23121342e0f163fe9d6ad. Script is sourced in the makefile, no need for +x.
2014-10-19pdf: fix compiler warningAdrian Johnson1-1/+1
2014-10-19CFF: Fix unaligned accessAdrian Johnson3-35/+58
Debian bug 712836 reported bus errors in cff subsetting when running on a sparc. This is because unlike truetype, all data in the compact font format is not aligned.
2014-10-17Add execution bit for make-cairo-test-constructors.shBryce Harrington1-0/+0
This is referenced in the Makefile but not set as executable
2014-10-17Update mime type documentation.Adrian Johnson1-1/+27
2014-10-16RELEASING: Update tags push commandBryce Harrington1-1/+1
I couldn't get the documented command to do diddly. Running `git push --tags` achieved what I think was intended.
2014-10-13Start 1.14.1 developmentBryce Harrington1-1/+1
2014-10-13pattern: Restore dropped inclusion of cairoint.h1.14.0Bryce Harrington1-0/+2
Fixes failure in make release-check due by due to requirement that cairoint.h be the first include for source files.
2014-10-131.14.0 releaseBryce Harrington1-2/+2
2014-10-13NEWS: Flesh out docs for new APIsBryce Harrington2-3/+12
2014-10-13NEWS: Update with latest changes and finalize for releaseBryce Harrington1-5/+19
2014-10-12pdf: don't use '\' to split strings across multiple linesAdrian Johnson1-1/+1
The PDF interpreter in my printer does not handle this correctly. So instead we add the string delimiters '(' and ')' to each line.
2014-10-10image: Corrected extents calculationsBill Spitzak6-153/+176
New implementations of _cairo_pattern_sampled_area and _cairo_pattern_get_extents which produce a more accurate bounding box. These do not depend on side-effects of analyze_filter, can handle different horizontal and vertical scales, filters wider than 1 for down-scaling, and compute a somewhat tighter bounding box in most cases. I removed the pad output of _cairo_pattern_analyze_filter as it is unused. Reviewed-by: Bryce Harrington <>
2014-10-10xcb: Use image fallback for GOOD/BEST filtersBill Spitzak1-18/+16
It will not use the fallback if the symbols in the previous patch are turned on. Also some code rearrangement to make this resemble the xlib version more and to remove some suspect bugs. In particular meshes should not work just because the translation is an integer. Reviewed-by: Bryce Harrington <>
2014-10-10xcb: Add switches for whether XRender supports GOOD/BEST filteringBill Spitzak2-1/+15
Currently these are always false, but if XRender use a pixman that supports filtering these could be turned on for that version. Reviewed-by: Bryce Harrington <>
2014-10-10xlib: Use image fallback for GOOD/BEST filtersBill Spitzak1-9/+14
Fallback is not used if the symbols defined in the previous patch to indicate if XRender does GOOD/BEST are true. This patch also includes some changes to take advantage of the fact that if there is an integer translation analyze_filter will already have set the filter to NEAREST. Reviewed-by: Bryce Harrington <>