summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEmanuele Aina <emanuele.aina@collabora.com>2014-12-16 14:58:55 +0100
committerAndrea Canciani <ranma42@gmail.com>2015-01-20 18:14:52 +0100
commitcca8b1960b0091c53235d9dc4cde8a33010c5bbf (patch)
tree8724572c6c941a03f8b1a815195ef3ad832a5f91
parentebd23accc8722db838f6db12f7489f16fe6016ce (diff)
cairo-trace: Fix duplicated surface push on similar-image
The current code results in trace lines with the source surface being pushed on the stack two times instead of one: s1 s1 //ARGB32 48 48 similar-image % s2 Instead of: s1 //ARGB32 48 48 similar-image % s2 This greatly confuses later commands when the script was replayed, causing traces for trivial GTK3 programs to be unplayable, usually yielding the following error: "invalid value (typically too big) for the size of the input (surface, pattern, etc.)" Drop the duplicated entry from the trace line printed by the cairo_surface_create_similar_image() override. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73580 Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>
-rw-r--r--util/cairo-trace/trace.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/util/cairo-trace/trace.c b/util/cairo-trace/trace.c
index 4d3482646..d5d76689c 100644
--- a/util/cairo-trace/trace.c
+++ b/util/cairo-trace/trace.c
@@ -3738,8 +3738,7 @@ cairo_surface_create_similar_image (cairo_surface_t *other,
else
_trace_printf ("%d index ",
current_stack_depth - other_obj->operand - 1);
- _trace_printf ("s%ld //%s %d %d similar-image %% s%ld\n",
- _get_surface_id (other),
+ _trace_printf ("//%s %d %d similar-image %% s%ld\n",
_format_to_string (format),
width, height,
new_obj->token);