From 625d70721dc5efbe4dea19030b16f1dc0a94646d Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Sat, 19 Mar 2022 11:02:39 +0100 Subject: dnsmasq/shared: drop "--dhcp-lease-max=50" option It's not clear why this option is set or why it's necessary. It was set ever since. Note that we automatically determine the DHCP range nm_dnsmasq_utils_get_range(), and with /24 subnets (or larger) the range spans up to 244 addresses. With such a configuration it doesn't seem to make sense to limit the number of leases. https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/ ## 941 --- src/core/dnsmasq/nm-dnsmasq-manager.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/dnsmasq/nm-dnsmasq-manager.c b/src/core/dnsmasq/nm-dnsmasq-manager.c index 4ab91e7e33..c272a743af 100644 --- a/src/core/dnsmasq/nm-dnsmasq-manager.c +++ b/src/core/dnsmasq/nm-dnsmasq-manager.c @@ -188,8 +188,6 @@ create_dm_cmd_line(const char *iface, nm_strv_ptrarray_add_string_dup(cmd, "--dhcp-option-force=43,ANDROID_METERED"); } - nm_strv_ptrarray_add_string_dup(cmd, "--dhcp-lease-max=50"); - nm_strv_ptrarray_add_string_printf(cmd, "--dhcp-leasefile=%s/dnsmasq-%s.leases", NMSTATEDIR, -- cgit v1.2.3