summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-03-06nmcli: set LESSSECURE=1 (unless already set)lr/make-less-less-insecureLubomir Rintel1-0/+1
Apparently, the pager being able to execute commands takes some people by surprpise, making their poor configuration choices have consequences. Let's pray for some mercy on their souls with the LESSECURE variable, which makes less less likely to conduct evil deeds. Systemd also deals with this, but being systemd they make it as complicated as possible. We just set it unconditionally, hoping nobody wanted the extra functionality and they're in only for the scrolling. If anyone minds they can just set LESSSECURE=0 and we'll leave it alone. See also: SYSTEMD_PAGERSECURE in systemctl(1) manual.
2023-03-06po/ca: fixes to Catalan translationJordi Mas1-7/+7
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1556
2023-03-03connectivity: avoid uninitialized variable warning in ↵Thomas Haller1-12/+6
nm_connectivity_check_start() In file included from ./src/libnm-std-aux/nm-default-std.h:102, from ./src/libnm-glib-aux/nm-default-glib.h:11, from ./src/libnm-glib-aux/nm-default-glib-i18n-prog.h:13, from ./src/core/nm-default-daemon.h:11, from src/core/nm-connectivity.c:8: src/core/nm-connectivity.c: In function ‘nm_connectivity_check_start’: ./src/libnm-std-aux/nm-std-aux.h:180:12: error: ‘reason’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (expr) \ ^ src/core/nm-connectivity.c:1055:29: note: ‘reason’ was declared here const char *reason; ^~~~~~
2023-03-03platform/tests: avoid accessing in_addr_t via NMIPAddr unionThomas Haller1-2/+6
The compiler may dislike this: CC src/core/platform/tests/libNetworkManagerTest_la-test-common.lo In function '_ip_address_add', inlined from 'nmtstp_ip4_address_add' at ../src/core/platform/tests/test-common.c:1892:5: ../src/core/platform/tests/test-common.c:1807:63: error: array subscript 'NMIPAddr {aka const struct _NMIPAddr}[0]' is partly outside array bounds of 'in_addr_t[1]' {aka 'unsigned int[1]'} [-Werror=array-bounds] 1807 | peer_address->addr4, | ~~~~~~~~~~~~^~~~~~~ ../src/core/platform/tests/test-common.c: In function 'nmtstp_ip4_address_add': ../src/core/platform/tests/test-common.c:1886:36: note: object 'peer_address' of size 4 1886 | in_addr_t peer_address, | ~~~~~~~~~~~~^~~~~~~~~~~~ ... Fixes: 06aafabf14e6 ('platform/test: add test adding IPv4 addresses that only differ by their peer-address')
2023-03-03contrib: install more packages in "nm-in-container.sh"Thomas Haller1-0/+3
2023-03-03merge: branch 'bg/dnsmasq-global-conf'Beniamino Galvani2-7/+13
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1555
2023-03-03man: update documentation about global DNS configurationbg/dnsmasq-global-confBeniamino Galvani1-6/+11
Now the settings in the [global-dns] section are used *in addition* to connection-specific ones. Only the global domains sections, when valid, override connection settings. Update the man page to clarify that. Fixes: 1f0d1d78d2a2 ('dns-manager: always apply options from [global-dns]')
2023-03-03dnsmasq: process both global and per-device configurationBeniamino Galvani1-1/+2
The global configuration now can be valid when there are no global domains defined. The dnsmasq backend must process it and then, if there is no global default domain, also process the per-connection settings. Fixes: 1f0d1d78d2a2 ('dns-manager: always apply options from [global-dns]')
2023-03-03contrib: add usage comment to "git-subtree-reimport.sh"Thomas Haller1-0/+9
2023-03-03c-stdaux: re-import git-subtree for 'src/c-stdaux'Thomas Haller5-1/+345
git subtree pull --prefix src/c-stdaux git@github.com:c-util/c-stdaux.git main --squash
2023-03-03Squashed 'src/c-stdaux/' changes from eceefe959250..699c20de4e81Thomas Haller5-1/+345
699c20de4e81 c-stdaux: workaround warning "-Wunused-value" in c_internal_assume_aligned() 193444c22c09 c-stdaux: workaround compiler error with clang 3.4 and __builtin_assume_aligned() ed5fee49a3ec build: prepare v1.4.0 615c52daed67 Merge pull request #14 from dvdhrm/pr/load 32462ddc2ea5 c-stdaux: add c_load*() helpers 5878375d81ba c-stdaux: add c_assume_aligned() git-subtree-dir: src/c-stdaux git-subtree-split: 699c20de4e81f4b15786cb170340a87f69483f3d
2023-03-03platform: fix test_link_set_properties()Beniamino Galvani1-3/+4
The link object is no longer valid after the cache gets updated in nm_platform_link_change(). Fixes: e02fd76d9fce ('platform: support changing link properties')
2023-03-03merge: branch 'bg/link-setting'Beniamino Galvani29-21/+761
https://bugzilla.redhat.com/show_bug.cgi?id=2158328 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1541
2023-03-02device: manually update link properties for ovs interfacesbg/link-settingBeniamino Galvani3-4/+10
OVS interfaces are special: the kernel link is created only after the device is attached to the ovs-port, and as with all ports this happens during stage3(ip-config). That means that the link doesn't exist during stage2(config); therefore, explicitly update link properties once the link appears.
2023-03-02device: set link propertiesBeniamino Galvani1-2/+159
Set link properties during activation and restore the previous values on deactivation.
2023-03-02platform: support changing link propertiesBeniamino Galvani4-1/+150
Add support in platform for changing the newly introduced link properties.
2023-03-02all: add "link" settingBeniamino Galvani21-3/+423
Introduce a new "link" setting that holds properties that are related to the kernel link.
2023-03-02libnm-core: remove assertion in testBeniamino Galvani1-2/+0
It's another place to change when adding a new setting and it doesn't seem useful to assert that the number is exactly 54.
2023-03-02libnmc-setting: allow the "match" setting for some port connectionsBeniamino Galvani1-0/+4
A {bond, bridge, team, ovs-port} port profile should support a "match" setting.
2023-03-02platform: rename link_change() to link_change_extra()Beniamino Galvani3-13/+19
There are many functions to replace properties of a link (link_set_address, link_set_mtu, link_set_name, link_change, etc.). Eventually, they will be replaced by a function that does everything and removes all the code duplication. That function will be named link_change(); rename the current link_change() to link_change_extra().
2023-03-02device: reconfigure ethtool and tc also for assumed devicesBeniamino Galvani1-2/+2
We need to set the ethtool and tc properties for assumed devices, since they go through a normal activation. External devices should not be touched by NM.
2023-03-02settings: preserve existing connection flags on updatebg/connection-flagsBeniamino Galvani1-2/+6
We are passing to the plugin only 'sett_flags', which is the bitmask of flags to change and works together with 'sett_mask'; however, plugins interpret that value as the new flags value. The result is that if there is no change needed (0/0), the existing flags are lost. Simple reproducer: ip link add dummy1 type dummy ip link set dummy1 up ip addr add dev dummy1 fd01::12/64 sleep 1 # now, a external connection is created by NM echo "BEFORE:" cat /run/NetworkManager/system-connections/dummy1.nmconnection | grep "nm-generated\|volatile\|external" # just add a new address to the interface to make it lose # the external flag ip addr add dev dummy1 172.25.42.1/24 sleep 1 echo "AFTER:" cat /run/NetworkManager/system-connections/dummy1.nmconnection | grep "nm-generated\|volatile\|external" Output: BEFORE: nm-generated=true volatile=true external=true AFTER: Fixes: d35d3c468a30 ('settings: rework tracking settings connections and settings plugins') https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1548
2023-03-01platform: fix bridge test with fake platformBeniamino Galvani2-28/+85
Fixes: 5afb323ed8d4 ('platform/tests: add test for nm_platform_link_set_bridge_info()') https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1552
2023-03-01merge: branch 'fix-suiteb'Beniamino Galvani1-0/+4
nmcli: add WPA-EAP-SUITE-B-192 to SECURITY when ap is wpa-eap-suite-b-192 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1527
2023-03-01nmcli: add WPA-EAP-SUITE-B-192 to SECURITYliaohanqin1-0/+4
2023-03-01platform/tests: add test for nm_platform_link_set_bridge_info()Thomas Haller1-4/+48
2023-03-01bridge: set vlan_filtering and vlan_default_pvid via netlinkVladislav Tsisyk4-16/+106
This commit changes setting values of said attributes from writing string to sysfs to sending Netlink message. https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1499
2023-03-01ifcfg-rh: fix wrong (transfer-full) annotation in internal codeThomas Haller1-1/+1
The annotation is wrong. However, we don't generate gtk-doc/introspection data for such internal code, so it doesn't really matter.
2023-02-28build: add test for checking consistency of "nm-autoptr.h"Thomas Haller3-2/+39
2023-02-28libnm: add missing types to "nm-autoptr.h" headerThomas Haller1-1/+7
2023-02-28vapi: merge branch 'tintou/gir-fixes'Thomas Haller6-24/+142
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1545
2023-02-28vapi: add test for consistency of "vapi/NM-1.0.metadata"Thomas Haller3-0/+36
2023-02-28vapi: Add several namespace changes and more specific types for propertiesCorentin Noël1-19/+75
Add overrides for properties constants of new objects to allow to match them with their object type as it was the case for former objects. Specify the types of properties with element-types. Namespace Attributes so that they are logically sorted. Remove several skips to allow to use the entirety of the visible methods.
2023-02-28libnm/connection: Add missing annotations to nm_connection_diffCorentin Noël1-4/+29
Allows to use this function in GObject introspected languages. Also workaround a current issue with the gtk-doc parser not taking nested element-type into account.
2023-02-28libnm: Specify the main header in the .gir fileCorentin Noël2-1/+2
Bindings compiling to C need to know which main header to include.
2023-02-28platform: merge branch 'th/platform-nl-extack-msg'Thomas Haller11-173/+279
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1543
2023-02-28platform: minor refactoring of temporary-not-available routesThomas Haller1-25/+38
This will be used also for IPv4 addresses. Rename and make the function more generally useful.
2023-02-28platform: get extack_msg innm_platform_ip_route_sync()Thomas Haller1-3/+5
Request the extack_msg for nm_platform_ip_route_add() call. Note that we (currently) don't do anything with it, however requesting it has no downsides. That is, the message already is heap allocated in the lower layers, so this only affects whether it will be returned up to nm_platform_ip_route_sync().
2023-02-28platform: return extack message from add address/route operationsThomas Haller9-46/+100
2023-02-28platform: drop logging for unexpected sequence numberThomas Haller1-14/+1
It is not clear how that information is relevant. Since it is also only logged when building with a non-default configure option, this doesn't seem useful. Drop it.
2023-02-28platform: minor cleanup of event_seq_check()Thomas Haller1-13/+16
- unindent the code by "continue" the loop for the irrelevant case. - fix indentation of comments. - avoid unnecessary g_strdup() call if the extack message is NULL.
2023-02-28platform: log extack warning messages for netlink requestsThomas Haller2-9/+22
The extack can also be returned on success. In that case, they are warnings. Log them, it might be useful.
2023-02-28platform: rename variables for extack messageThomas Haller1-39/+39
Consistently name those variables and parameters "extack_msg". The previous term "errmsg"/"msg" was not used consistently, and it is also not clear what message this really is. For netlink, it is well understood what Extended ACK means.
2023-02-28platform/netlink: cleanup nla_strlcpy() to not wipe remaining bufferThomas Haller2-27/+50
strlcpy()/g_strlcpy() has a well understood behavior. nla_strlcpy() did not behave like that. Instead, it also used to always wipe the remainder of the string, similar to what strncpy() would do. True, if we do nla_strlcpy(obj->link.name, tb[IFLA_IFNAME], IFNAMSIZ); then we might want to clear the remainder and don't care about the overhead of writing up to 14 bytes unnecessarily... However, actually all callers of nla_strlcpy() either operate on a buffer that is already pre-inialized with zero, or they really don't care about the uninitialized memory after the string. So this was nowhere the desired behavior. Change nla_strlcpy() to not wipe the remainder of the buffer, so it behaves mostly like strlcpy()/g_strlcpy() and as one would expect. Add nla_strlcpy_wipe(), which on top of it also clears the remaining buffer. In that aspect, it bears some similarities with strncpy(), but it differs in other regards from strncpy (always NUL terminating and returning the srclen). Yes, the name nla_strlcpy_wipe() is maybe unfamiliar to the user, but it really is like nla_strlcpy() with the addition to clear the buffer. That seems simple enough to understand based on the name. Note that all existing callers of nla_strlcpy() do not care about clearing the memory, and the change in behavior is fine for them.
2023-02-28platform/netlink: assert for valid string in nla_get_string()Thomas Haller1-1/+12
2023-02-28libnm: merge branch 'champtar:route-unreachable'Thomas Haller3-3/+3
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1549
2023-02-28platform/trivial: fix route type name (unavailable -> unreachable)Etienne Champetier1-1/+1
Fixes: 766349879ed2 ('platform/trivial: add code comments for NMPGlobalTracker')
2023-02-28doc: fix route type name (unavailable -> unreachable)Etienne Champetier2-2/+2
Fixes: 1cc3d00cb76b ('libnm/doc: list route attributes in `man nm-settings-nmcli`')
2023-02-27libnm: drop _NMConnectionForEachSecretFunc from public headersThomas Haller2-3/+2
It was always a private typedef. Not meant to be used. This was left over since commit e46d484fae9e ('libnm: hide NMSetting types from public headers')
2023-02-27cloud-setup: use nm_strv_dup_packed() in nm_http_client_poll_get()Thomas Haller1-2/+7
No need to do a deep clone. The strv array is not ever modified and we pack it together in one memory allocation.
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 01:06:59 +0000