summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAntonio Cardace <acardace@redhat.com>2020-10-22 14:40:15 +0200
committerAntonio Cardace <acardace@redhat.com>2020-10-22 17:38:08 +0200
commitb6a18e059302117157971e7c5f551fc40d864e89 (patch)
treeb92b0168cf3d929897f49e9ed8f6c7ca1167ddf5
parent6e44842dc69d03549e1a3bd842988308d2969fd3 (diff)
manager: fix very bad usage of 'nm_utils_user_data_unpack'
This results in the args of 'nm_utils_user_data_unpack' containing random data potentially also from the previous stack-frame which is really really bad. Signed-off-by: Antonio Cardace <acardace@redhat.com> Fixes: b50702775f1b ('device: implement auth-request as async operation nm_manager_device_auth_request()')
-rw-r--r--src/nm-manager.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/nm-manager.c b/src/nm-manager.c
index a04ca0e6d..ec5ca6ef0 100644
--- a/src/nm-manager.c
+++ b/src/nm-manager.c
@@ -2445,7 +2445,8 @@ _device_auth_done_fail_on_idle(gpointer user_data, GCancellable *cancellable)
NMManagerDeviceAuthRequestFunc callback;
gpointer callback_user_data;
- nm_utils_user_data_unpack(&self,
+ nm_utils_user_data_unpack(user_data,
+ &self,
&device,
&context,
&subject,