diff options
| author | Dan Williams <dcbw@redhat.com> | 2010-09-22 13:43:23 -0500 |
|---|---|---|
| committer | Dan Williams <dcbw@redhat.com> | 2010-09-22 13:44:18 -0500 |
| commit | a1731c60644432cdec94841a033340bfc88568ec (patch) | |
| tree | 00713533685ddbf550457e7939ba12f41f732d38 | |
| parent | 0ec9bf2c73c9c73cbbe6e757c0857c67be971575 (diff) | |
libnm-util: fix max APN length
It's not 20, it's DNS domain name length.
| -rw-r--r-- | libnm-util/nm-setting-gsm.c | 2 | ||||
| -rw-r--r-- | libnm-util/tests/test-general.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/libnm-util/nm-setting-gsm.c b/libnm-util/nm-setting-gsm.c index 575f94d382..e9d06bea10 100644 --- a/libnm-util/nm-setting-gsm.c +++ b/libnm-util/nm-setting-gsm.c @@ -235,7 +235,7 @@ verify (NMSetting *setting, GSList *all_settings, GError **error) guint32 apn_len = strlen (priv->apn); guint32 i; - if (apn_len < 1 || apn_len > 20) { + if (apn_len < 1 || apn_len > 64) { g_set_error (error, NM_SETTING_GSM_ERROR, NM_SETTING_GSM_ERROR_INVALID_PROPERTY, diff --git a/libnm-util/tests/test-general.c b/libnm-util/tests/test-general.c index 855ee083fb..e91e2b5ce2 100644 --- a/libnm-util/tests/test-general.c +++ b/libnm-util/tests/test-general.c @@ -283,8 +283,8 @@ test_setting_gsm_apn_bad_chars (void) ASSERT (nm_setting_verify (NM_SETTING (s_gsm), NULL, NULL) == FALSE, "gsm-apn-bad-chars", "unexpectedly valid GSM setting"); - /* 21-character long */ - g_object_set (s_gsm, NM_SETTING_GSM_APN, "abcdefghijklmnopqrstu", NULL); + /* 65-character long */ + g_object_set (s_gsm, NM_SETTING_GSM_APN, "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkl1", NULL); ASSERT (nm_setting_verify (NM_SETTING (s_gsm), NULL, NULL) == FALSE, "gsm-apn-bad-chars", "unexpectedly valid GSM setting"); } |