From 44175db16c4ad83a35a0661a3758c90b3cf2ce8c Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Mon, 6 Jul 2020 16:23:57 +0200 Subject: cinterion: if user OR password given, don't set the other as (null) [modem2/ttyACM1/at] --> 'AT^SGAUTH=8,1,t-d1,(null)' [modem2/ttyACM1/at] <-- '+CME ERROR: 4' We should use an empty string instead. (cherry picked from commit 0a89a9ae4ee62ba36b616fc444a866d61c203696) --- plugins/cinterion/mm-broadband-bearer-cinterion.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/plugins/cinterion/mm-broadband-bearer-cinterion.c b/plugins/cinterion/mm-broadband-bearer-cinterion.c index ff9d008c..a4ee87d2 100644 --- a/plugins/cinterion/mm-broadband-bearer-cinterion.c +++ b/plugins/cinterion/mm-broadband-bearer-cinterion.c @@ -236,7 +236,11 @@ build_auth_string (MMBroadbandBearerCinterion *self, encoded_auth = BEARER_CINTERION_AUTH_PAP; } - return g_strdup_printf ("^SGAUTH=%u,%d,%s,%s", cid, encoded_auth, passwd, user); + return g_strdup_printf ("^SGAUTH=%u,%d,%s,%s", + cid, + encoded_auth, + passwd ? passwd : "", + user ? user : ""); } /******************************************************************************/ -- cgit v1.2.3