diff options
author | Simon McVittie <simon.mcvittie@collabora.co.uk> | 2011-09-16 17:40:29 +0100 |
---|---|---|
committer | Simon McVittie <simon.mcvittie@collabora.co.uk> | 2011-09-28 19:00:11 +0100 |
commit | 6934bc6927a3846d096bd3549f0ed06c901bb9f2 (patch) | |
tree | 15de860bfd12e9e223175768d07a6a8ecfa871ef | |
parent | ba033709b54df18bbe48b22303e0c3d514f547f8 (diff) |
Simplify generation of bus configuration files
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41222
10 files changed, 12 insertions, 21 deletions
diff --git a/cmake/CMakeLists.txt b/cmake/CMakeLists.txt index 21728a70..cfba103d 100644 --- a/cmake/CMakeLists.txt +++ b/cmake/CMakeLists.txt @@ -478,9 +478,7 @@ add_definitions(${DBUS_BUS_CFLAGS}) if (DBUS_BUILD_TESTS) # set variables used for the .in files (substituted by configure_file) in test/data: - set(TEST_VALID_SERVICE_DIR ${CMAKE_BINARY_DIR}/test/data/valid-service-files) - set(TEST_VALID_SERVICE_SYSTEM_DIR ${CMAKE_BINARY_DIR}/test/data/valid-service-files-system) - set(TEST_INVALID_SERVICE_SYSTEM_DIR ${CMAKE_BINARY_DIR}/test/data/invalid-service-files-system) + set(DBUS_TEST_DATA ${CMAKE_BINARY_DIR}/test/data) set(TEST_SOCKET_DIR ${DBUS_SESSION_SOCKET_DIR} ) set(TEST_LAUNCH_HELPER_BINARY ${EXECUTABLE_OUTPUT_PATH}/dbus-daemon-launch-helper-test) set(TEST_PRIVSERVER_BINARY ${EXECUTABLE_OUTPUT_PATH}/test-privserver) diff --git a/configure.ac b/configure.ac index 66bcf20a..6c2e2b51 100644 --- a/configure.ac +++ b/configure.ac @@ -1519,12 +1519,6 @@ DBUS_PWD=`pwd` # Useful in a cross-compilation environment, where the tests are run on the host system. AC_ARG_WITH(dbus-test-dir, AS_HELP_STRING([--with-dbus-test-dir=[dirname]],[path where the tests tools are available]), DBUS_PWD=$withval) -AC_DEFUN([TEST_PATH], [ -TEST_$1=${DBUS_PWD}/test/$2 -AC_DEFINE_UNQUOTED(TEST_$1, "$TEST_$1", - [Full path to test file test/$2 in builddir]) -AC_SUBST(TEST_$1) -]) AC_DEFUN([TEST_PROG], [ TEST_$1=${DBUS_PWD}/test/$2 AC_DEFINE_UNQUOTED(TEST_$1, "$TEST_$1$EXEEXT", @@ -1532,10 +1526,9 @@ AC_DEFINE_UNQUOTED(TEST_$1, "$TEST_$1$EXEEXT", AC_SUBST(TEST_$1) ]) -TEST_PATH(VALID_SERVICE_DIR, data/valid-service-files) -TEST_PATH(INVALID_SERVICE_DIR, data/invalid-service-files) -TEST_PATH(VALID_SERVICE_SYSTEM_DIR, data/valid-service-files-system) -TEST_PATH(INVALID_SERVICE_SYSTEM_DIR, data/invalid-service-files-system) +DBUS_TEST_DATA="$DBUS_PWD/test/data" +AC_SUBST([DBUS_TEST_DATA]) + TEST_PROG(SERVICE_BINARY, test-service) TEST_PROG(SHELL_SERVICE_BINARY, test-shell-service) TEST_PROG(EXIT_BINARY, test-exit) diff --git a/test/data/valid-config-files-system/debug-allow-all-fail.conf.cmake b/test/data/valid-config-files-system/debug-allow-all-fail.conf.cmake index 0c73d8c9..854bfe9c 100644 --- a/test/data/valid-config-files-system/debug-allow-all-fail.conf.cmake +++ b/test/data/valid-config-files-system/debug-allow-all-fail.conf.cmake @@ -6,7 +6,7 @@ <listen>@TEST_LISTEN@</listen> <type>system</type> <servicehelper>@TEST_LAUNCH_HELPER_BINARY@</servicehelper> - <servicedir>@TEST_INVALID_SERVICE_SYSTEM_DIR@</servicedir> + <servicedir>@DBUS_TEST_DATA@/invalid-service-files-system</servicedir> <policy context="default"> <allow send_interface="*"/> <allow receive_interface="*"/> diff --git a/test/data/valid-config-files-system/debug-allow-all-fail.conf.in b/test/data/valid-config-files-system/debug-allow-all-fail.conf.in index 93a548ce..a61244b6 100644 --- a/test/data/valid-config-files-system/debug-allow-all-fail.conf.in +++ b/test/data/valid-config-files-system/debug-allow-all-fail.conf.in @@ -7,7 +7,7 @@ <listen>unix:tmpdir=@TEST_SOCKET_DIR@</listen> <type>system</type> <servicehelper>@TEST_LAUNCH_HELPER_BINARY@</servicehelper> - <servicedir>@TEST_INVALID_SERVICE_SYSTEM_DIR@</servicedir> + <servicedir>@DBUS_TEST_DATA@/invalid-service-files-system</servicedir> <policy context="default"> <allow send_interface="*"/> <allow receive_interface="*"/> diff --git a/test/data/valid-config-files-system/debug-allow-all-pass.conf.cmake b/test/data/valid-config-files-system/debug-allow-all-pass.conf.cmake index d46ec184..1ac5c205 100644 --- a/test/data/valid-config-files-system/debug-allow-all-pass.conf.cmake +++ b/test/data/valid-config-files-system/debug-allow-all-pass.conf.cmake @@ -6,7 +6,7 @@ <listen>@TEST_LISTEN@</listen> <type>system</type> <servicehelper>@TEST_LAUNCH_HELPER_BINARY@</servicehelper> - <servicedir>@TEST_VALID_SERVICE_SYSTEM_DIR@</servicedir> + <servicedir>@DBUS_TEST_DATA@/valid-service-files-system</servicedir> <policy context="default"> <allow send_interface="*"/> <allow receive_interface="*"/> diff --git a/test/data/valid-config-files-system/debug-allow-all-pass.conf.in b/test/data/valid-config-files-system/debug-allow-all-pass.conf.in index 5b7ffd1a..6105d841 100644 --- a/test/data/valid-config-files-system/debug-allow-all-pass.conf.in +++ b/test/data/valid-config-files-system/debug-allow-all-pass.conf.in @@ -7,7 +7,7 @@ <listen>unix:tmpdir=@TEST_SOCKET_DIR@</listen> <type>system</type> <servicehelper>@TEST_LAUNCH_HELPER_BINARY@</servicehelper> - <servicedir>@TEST_VALID_SERVICE_SYSTEM_DIR@</servicedir> + <servicedir>@DBUS_TEST_DATA@/valid-service-files-system</servicedir> <policy context="default"> <allow send_interface="*"/> <allow receive_interface="*"/> diff --git a/test/data/valid-config-files/debug-allow-all-sha1.conf.cmake b/test/data/valid-config-files/debug-allow-all-sha1.conf.cmake index 416267c1..0c66f2ae 100644 --- a/test/data/valid-config-files/debug-allow-all-sha1.conf.cmake +++ b/test/data/valid-config-files/debug-allow-all-sha1.conf.cmake @@ -4,7 +4,7 @@ "http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd"> <busconfig> <listen>@TEST_LISTEN@</listen> - <servicedir>@TEST_VALID_SERVICE_DIR@</servicedir> + <servicedir>@DBUS_TEST_DATA@/valid-service-files</servicedir> <auth>DBUS_COOKIE_SHA1</auth> <policy context="default"> <allow send_interface="*"/> diff --git a/test/data/valid-config-files/debug-allow-all-sha1.conf.in b/test/data/valid-config-files/debug-allow-all-sha1.conf.in index 34c50856..ba68f453 100644 --- a/test/data/valid-config-files/debug-allow-all-sha1.conf.in +++ b/test/data/valid-config-files/debug-allow-all-sha1.conf.in @@ -5,7 +5,7 @@ <busconfig> <listen>debug-pipe:name=test-server</listen> <listen>unix:tmpdir=@TEST_SOCKET_DIR@</listen> - <servicedir>@TEST_VALID_SERVICE_DIR@</servicedir> + <servicedir>@DBUS_TEST_DATA@/valid-service-files</servicedir> <auth>DBUS_COOKIE_SHA1</auth> <policy context="default"> <allow send_interface="*"/> diff --git a/test/data/valid-config-files/debug-allow-all.conf.cmake b/test/data/valid-config-files/debug-allow-all.conf.cmake index 94bb21e7..adc3aa59 100644 --- a/test/data/valid-config-files/debug-allow-all.conf.cmake +++ b/test/data/valid-config-files/debug-allow-all.conf.cmake @@ -4,7 +4,7 @@ "http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd"> <busconfig> <listen>@TEST_LISTEN@</listen> - <servicedir>@TEST_VALID_SERVICE_DIR@</servicedir> + <servicedir>@DBUS_TEST_DATA@/valid-service-files</servicedir> <policy context="default"> <allow send_interface="*"/> <allow receive_interface="*"/> diff --git a/test/data/valid-config-files/debug-allow-all.conf.in b/test/data/valid-config-files/debug-allow-all.conf.in index 3514296f..a086976b 100644 --- a/test/data/valid-config-files/debug-allow-all.conf.in +++ b/test/data/valid-config-files/debug-allow-all.conf.in @@ -5,7 +5,7 @@ <busconfig> <listen>debug-pipe:name=test-server</listen> <listen>unix:tmpdir=@TEST_SOCKET_DIR@</listen> - <servicedir>@TEST_VALID_SERVICE_DIR@</servicedir> + <servicedir>@DBUS_TEST_DATA@/valid-service-files</servicedir> <policy context="default"> <allow send_interface="*"/> <allow receive_interface="*"/> |