Replace the check_aperture API with one we can make thread-safe.drm-gem

While the bufmgr isn't thread-safe at the moment, we need it to be for shared
objects between contexts.

4 files changed, 43 insertions, 30 deletions

diff --git a/libdrm/dri_bufmgr.c b/libdrm/dri_bufmgr.c
index 7657df618..a6eda3bd9 100644
--- a/libdrm/dri_bufmgr.c
+++ b/libdrm/dri_bufmgr.c
@@ -135,7 +135,7 @@ dri_bufmgr_set_debug(dri_bufmgr *bufmgr, int enable_debug)
 }
 
 int
-dri_bufmgr_check_aperture_space(dri_bo *bo)
+dri_bufmgr_check_aperture_space(dri_bo **bo_array, int count)
 {
-    return bo->bufmgr->check_aperture_space(bo);
+	return bo_array[0]->bufmgr->check_aperture_space(bo_array, count);
 }
diff --git a/libdrm/dri_bufmgr.h b/libdrm/dri_bufmgr.h
index a5ae6c0fe..e67756bb1 100644
--- a/libdrm/dri_bufmgr.h
+++ b/libdrm/dri_bufmgr.h
@@ -146,7 +146,7 @@ struct _dri_bufmgr {
 
    void (*post_submit)(dri_bo *batch_buf);
 
-   int (*check_aperture_space)(dri_bo *bo);
+   int (*check_aperture_space)(dri_bo **bo_array, int count);
    int debug; /**< Enables verbose debugging printouts */
 };
 
@@ -169,6 +169,6 @@ void dri_bufmgr_destroy(dri_bufmgr *bufmgr);
 void *dri_process_relocs(dri_bo *batch_buf);
 void dri_post_process_relocs(dri_bo *batch_buf);
 void dri_post_submit(dri_bo *batch_buf);
-int dri_bufmgr_check_aperture_space(dri_bo *bo);
+int dri_bufmgr_check_aperture_space(dri_bo **bo_array, int count);
 
 #endif
diff --git a/libdrm/intel/intel_bufmgr_fake.c b/libdrm/intel/intel_bufmgr_fake.c
index e988eb58a..63dd9bef7 100644
--- a/libdrm/intel/intel_bufmgr_fake.c
+++ b/libdrm/intel/intel_bufmgr_fake.c
@@ -43,6 +43,8 @@
 #include "i915_drm.h"
 #include "mm.h"
 
+#define ALIGN(value, alignment)  ((value + alignment - 1) & ~(alignment - 1))
+
 #define DBG(...) do {					\
    if (bufmgr_fake->bufmgr.debug)			\
       drmMsg(__VA_ARGS__);				\
@@ -147,9 +149,6 @@ typedef struct _bufmgr_fake {
    int debug;
 
    int performed_rendering;
-
-   /* keep track of the current total size of objects we have relocs for */
-   unsigned long current_total_size;
 } dri_bufmgr_fake;
 
 typedef struct _dri_bo_fake {
@@ -159,8 +158,8 @@ typedef struct _dri_bo_fake {
    const char *name;
 
    unsigned dirty:1;
-   unsigned size_accounted:1; /*this buffers size has been accounted against the aperture */
-   unsigned card_dirty:1; /* has the card written to this buffer - we make need to copy it back */
+   /** has the card written to this buffer - we make need to copy it back */
+   unsigned card_dirty:1;
    unsigned int refcount;
    /* Flags may consist of any of the DRM_BO flags, plus
     * DRM_BO_NO_BACKING_STORE and BM_NO_FENCE_SUBDATA, which are the first two
@@ -179,6 +178,12 @@ typedef struct _dri_bo_fake {
    /** relocation list */
    struct fake_buffer_reloc *relocs;
    int nr_relocs;
+   /**
+    * Total size of the target_bos of this buffer.
+    *
+    * Used for estimation in check_aperture.
+    */
+   unsigned int child_size;
 
    struct block *block;
    void *backing_store;
@@ -189,8 +194,6 @@ typedef struct _dri_bo_fake {
 static int clear_fenced(dri_bufmgr_fake *bufmgr_fake,
 			unsigned int fence_cookie);
 
-static int dri_fake_check_aperture_space(dri_bo *bo);
-
 #define MAXFENCE 0x7fffffff
 
 static int FENCE_LTE( unsigned a, unsigned b )
@@ -855,9 +858,6 @@ dri_fake_bo_validate(dri_bo *bo)
       return 0;
    }
 
-   /* reset size accounted */
-   bo_fake->size_accounted = 0;
-
    /* Allocate the card memory */
    if (!bo_fake->block && !evict_and_alloc_block(bo)) {
       bufmgr_fake->fail = 1;
@@ -941,8 +941,6 @@ dri_fake_emit_reloc(dri_bo *reloc_buf,
    assert(reloc_buf);
    assert(target_buf);
 
-   assert(target_fake->is_static || target_fake->size_accounted);
-
    if (reloc_fake->relocs == NULL) {
       reloc_fake->relocs = malloc(sizeof(struct fake_buffer_reloc) *
 				  MAX_RELOCS);
@@ -954,6 +952,9 @@ dri_fake_emit_reloc(dri_bo *reloc_buf,
 
    dri_bo_reference(target_buf);
 
+   if (!target_fake->is_static)
+      reloc_fake->child_size += ALIGN(target_buf->size, target_fake->alignment);
+
    r->target_buf = target_buf;
    r->offset = offset;
    r->last_target_offset = target_buf->offset;
@@ -1079,7 +1080,6 @@ dri_fake_process_relocs(dri_bo *batch_buf)
 
    assert(ret == 0);
 
-   bufmgr_fake->current_total_size = 0;
    return NULL;
 }
 
@@ -1117,26 +1117,39 @@ dri_fake_post_submit(dri_bo *batch_buf)
    dri_bo_fake_post_submit(batch_buf);
 }
 
+/**
+ * Return an error if the list of BOs will exceed the aperture size.
+ *
+ * This is a rough guess and likely to fail, as during the validate sequence we
+ * may place a buffer in an inopportune spot early on and then fail to fit
+ * a set smaller than the aperture.
+ */
 static int
-dri_fake_check_aperture_space(dri_bo *bo)
+dri_fake_check_aperture_space(dri_bo **bo_array, int count)
 {
-   dri_bufmgr_fake *bufmgr_fake = (dri_bufmgr_fake *)bo->bufmgr;
-   dri_bo_fake *bo_fake = (dri_bo_fake *)bo;
-   unsigned int sz;
+   dri_bufmgr_fake *bufmgr_fake = (dri_bufmgr_fake *)bo_array[0]->bufmgr;
+   unsigned int sz = 0;
+   int i;
 
-   sz = (bo->size + bo_fake->alignment - 1) & ~(bo_fake->alignment - 1);
+   for (i = 0; i < count; i++) {
+      dri_bo_fake *bo_fake = (dri_bo_fake *)bo_array[i];
 
-   if (bo_fake->size_accounted || bo_fake->is_static)
-      return 0;
+      if (bo_fake == NULL)
+	 continue;
+
+      if (!bo_fake->is_static)
+	 sz += ALIGN(bo_array[i]->size, bo_fake->alignment);
+      sz += bo_fake->child_size;
+   }
 
-   if (bufmgr_fake->current_total_size + sz > bufmgr_fake->size) {
-     DBG("check_space: %s bo %d %d overflowed bufmgr size %d\n", bo_fake->name, bo_fake->id, sz, bufmgr_fake->size);
+   if (sz > bufmgr_fake->size) {
+      DBG("check_space: overflowed bufmgr size, %dkb vs %dkb\n",
+	  sz / 1024, bufmgr_fake->size / 1024);
       return -1;
    }
 
-   bufmgr_fake->current_total_size += sz;
-   bo_fake->size_accounted = 1;
-   DBG("drm_check_space: buf %d, %s %d %d\n", bo_fake->id, bo_fake->name, bo->size, bufmgr_fake->current_total_size);
+   DBG("drm_check_space: sz %dkb vs bufgr %dkb\n", sz / 1024 ,
+       bufmgr_fake->size / 1024);
    return 0;
 }
 
diff --git a/libdrm/intel/intel_bufmgr_gem.c b/libdrm/intel/intel_bufmgr_gem.c
index f57322264..48752f2f5 100644
--- a/libdrm/intel/intel_bufmgr_gem.c
+++ b/libdrm/intel/intel_bufmgr_gem.c
@@ -873,7 +873,7 @@ intel_bufmgr_gem_enable_reuse(dri_bufmgr *bufmgr)
  *
  */
 static int
-dri_gem_check_aperture_space(dri_bo *bo)
+dri_gem_check_aperture_space(dri_bo *bo_array, int count)
 {
     return 0;
 }