authorEamon Walsh <>2009-09-22 20:13:03 (GMT)
committer Eamon Walsh <>2009-10-15 00:59:35 (GMT)
commite81a665ef210845911d2b03bcca4f6a05cb367d0 (patch) (side-by-side diff)
parent4a8cc895ccdb64945661747c75a118deea96b53a (diff)
xace: Relax permissions on XkbGetState from Read to Getattr.
This request is used to get the current keyboard group and is called from GTK. It does not return an actual keymap (aside from modifiers) so it should be safe to relax the permission on it. However it does return button state information which should be controlled through a separate pointer Read check. Signed-off-by: Eamon Walsh <> (cherry picked from commit c4ffce4dc84a0a9d134a59b7e7765c99ed767e53)
Diffstat (more/less context) (ignore whitespace changes)
1 files changed, 1 insertions, 1 deletions
diff --git a/xkb/xkb.c b/xkb/xkb.c
index 4ff2d5f..a62db7b 100644
--- a/xkb/xkb.c
+++ b/xkb/xkb.c
@@ -553,7 +553,7 @@ ProcXkbGetState(ClientPtr client)
if (!(client->xkbClientFlags&_XkbClientInitialized))
return BadAccess;
- CHK_KBD_DEVICE(dev, stuff->deviceSpec, client, DixReadAccess);
+ CHK_KBD_DEVICE(dev, stuff->deviceSpec, client, DixGetAttrAccess);
xkb= &dev->key->xkbInfo->state;