summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorConnor Abbott <cwabbott0@gmail.com>2020-07-03 18:44:56 +0200
committerMarge Bot <eric+marge@anholt.net>2020-07-24 18:43:40 +0000
commit9e596cc2c21a3542520604aceda6754cd2259941 (patch)
tree033d1aafec71179df5436aff1988a272ba179bd3
parentf7f29a04b48393b44d08d94afe0d4dab3ba75335 (diff)
tu: Enable vertex & fragment stores & atomics
Note that there are some extra tess fails, but they're probably unrelated to the actual feature. There were also some xfails that were created as part of an earlier attempt to enable the feature which were fixed in the meantime, so remove them. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5738>
-rw-r--r--.gitlab-ci/deqp-freedreno-a630-fails.txt6
-rw-r--r--src/freedreno/vulkan/tu_device.c4
2 files changed, 6 insertions, 4 deletions
diff --git a/.gitlab-ci/deqp-freedreno-a630-fails.txt b/.gitlab-ci/deqp-freedreno-a630-fails.txt
index 274cfd6239a..ed5b3c4e6a7 100644
--- a/.gitlab-ci/deqp-freedreno-a630-fails.txt
+++ b/.gitlab-ci/deqp-freedreno-a630-fails.txt
@@ -7,8 +7,6 @@ dEQP-VK.binding_model.descriptorset_random.sets4.constant.ubolimitlow.sbolimithi
dEQP-VK.draw.output_location.array.b8g8r8a8-unorm-mediump-output-vec3
dEQP-VK.glsl.linkage.varying.struct.mat3x2
dEQP-VK.graphicsfuzz.mat-array-deep-control-flow
-dEQP-VK.pipeline.spec_constant.graphics.geometry.composite.array.array_vec4
-dEQP-VK.pipeline.spec_constant.graphics.vertex.composite.array.mat4x3
dEQP-VK.renderpass2.dedicated_allocation.formats.d24_unorm_s8_uint.input.load.store.self_dep_draw_stencil_read_only
dEQP-VK.renderpass.dedicated_allocation.formats.d24_unorm_s8_uint.input.clear.dont_care.clear_draw
dEQP-VK.renderpass.suballocation.formats.d24_unorm_s8_uint.input.dont_care.dont_care.draw_use_input_aspect
@@ -17,3 +15,7 @@ dEQP-VK.spirv_assembly.instruction.compute.float_controls.fp32.input_args.negate
dEQP-VK.spirv_assembly.instruction.compute.float_controls.fp32.input_args.rounding_rtz_out_prod
dEQP-VK.spirv_assembly.instruction.graphics.opquantize.carry_bit_geom
dEQP-VK.subgroups.builtin_var.graphics.subgroupinvocationid
+
+# not sure what's wrong here
+dEQP-VK.tessellation.invariance.outer_edge_index_independence.triangles_equal_spacing_ccw_point_mode
+dEQP-VK.tessellation.invariance.primitive_set.isolines_fractional_odd_spacing_ccw_point_mode
diff --git a/src/freedreno/vulkan/tu_device.c b/src/freedreno/vulkan/tu_device.c
index bf204021a56..75eabdc882f 100644
--- a/src/freedreno/vulkan/tu_device.c
+++ b/src/freedreno/vulkan/tu_device.c
@@ -623,8 +623,8 @@ tu_GetPhysicalDeviceFeatures(VkPhysicalDevice physicalDevice,
.textureCompressionBC = true,
.occlusionQueryPrecise = true,
.pipelineStatisticsQuery = false,
- .vertexPipelineStoresAndAtomics = false,
- .fragmentStoresAndAtomics = false,
+ .vertexPipelineStoresAndAtomics = true,
+ .fragmentStoresAndAtomics = true,
.shaderTessellationAndGeometryPointSize = false,
.shaderImageGatherExtended = false,
.shaderStorageImageExtendedFormats = false,