summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Huddleston <jeremyhu@freedesktop.org>2009-01-16 13:20:44 -0800
committerJeremy Huddleston <jeremyhu@freedesktop.org>2009-01-16 13:20:44 -0800
commite917a1cd30f720e6e51253c5041f02232522c9af (patch)
treeb54407e71c7bc2a8615fe7f22ab4da27d2620f6d
parentf020900641b44a1142e5c2198e9678de2744454e (diff)
Revert "mieq: Avoid possible race condition whereby one thread might call mieqEnqueue before InitAndStartDevices finishes"
This reverts commit 3c596c061e75848cfa76dd9259c23a3f3a67444c. Gonna do this in a less hackish way using a notification that the server is done initializing first.
-rw-r--r--mi/mieq.c11
1 files changed, 2 insertions, 9 deletions
diff --git a/mi/mieq.c b/mi/mieq.c
index 43cd0e725..15ba8e723 100644
--- a/mi/mieq.c
+++ b/mi/mieq.c
@@ -248,14 +248,7 @@ mieqEnqueue(DeviceIntPtr pDev, xEvent *e)
evt->event->u.keyButtonPointer.time = miEventQueue.lastEventTime;
miEventQueue.lastEventTime = evt->event->u.keyButtonPointer.time;
-
- /* Avoid possible crash when multithreaded and mieqEnqueue is called before
- * InitAndStartDevices finishes.
- */
- if(pDev && pDev->spriteInfo && pDev->spriteInfo->sprite)
- miEventQueue.events[oldtail].pScreen = EnqueueScreen(pDev);
- else
- miEventQueue.events[oldtail].pScreen = NULL;
+ miEventQueue.events[oldtail].pScreen = EnqueueScreen(pDev);
miEventQueue.events[oldtail].pDev = pDev;
miEventQueue.lastMotion = isMotion;
@@ -408,7 +401,7 @@ mieqProcessInputEvents(void)
/* Custom event handler */
handler = miEventQueue.handlers[type];
- if (screen && screen != DequeueScreen(dev) && !handler) {
+ if (screen != DequeueScreen(dev) && !handler) {
/* Assumption - screen switching can only occur on motion events. */
DequeueScreen(dev) = screen;
x = event->u.keyButtonPointer.rootX;