Correct undefined behavior access to out of scope pointer contents.HEADmaster

  This problem is triggered in gcc 4.7 DCE (dead code elimination).
In the Xaw code, the local constant "String" is not guaranteed to
have global scope.
  The problem was found when debugging the reason xedit built with
gcc 4.7 would be very unstable, and that happens regardless of using
a libXaw built with gcc 4.6.

Signed-off-by: pcpa <paulo.cesar.pereira.de.andrade@gmail.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/src/Text.c b/src/Text.c
index 72387e9..a1ae74a 100644
--- a/src/Text.c
+++ b/src/Text.c
@@ -3146,7 +3146,7 @@ _XawTextSetSelection(TextWidget ctx, XawTextPosition l, XawTextPosition r,
     if (nelems == 1 && !strcmp (list[0], "none"))
 	return;
     if (nelems == 0) {
-	String defaultSel = "PRIMARY";
+	static String defaultSel = "PRIMARY";
 	list = &defaultSel;
 	nelems = 1;
     }